Re: xt_time 2007-09-22

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Sep 22 2007 17:19, Patrick McHardy wrote:
>   
>> A thought just occured to me (a bit late, but better than never :) ..
>>
>> Can't we just convert the user-specified times/dates to unix time
>> and match on that without all these expensive calculations? At least
>> for pure time matching without days this should work fine ..
>>     
>
> Pure time matching (--datestart, --datestop) already use unix timing.
>   
Right, I missed that.

> Daytime (--timestart) ... I wonder how you'd model
> "from 12:00 to 13:00, each day" other than it is done now.
> Same for weekday.
>   

You're right again, that doesn't seem to be possible.

> Leaves monthday matching, which could probably be done with some more
> static tables, but I'd have to dig up some old encyclopedia from 1972
> and see how they did it.
>   

I guess that will be a very rarely used feature anyway, don't
bother.

>   
>>> +	localtime_3(&current_time, stamp);
>>> +
>>> +	if (!(info->monthdays_match & (1 << current_time.monthday)))
>>> +		return false;
>>>   
>>>       
>> I'd add a flag or check whether weekdays_match/monthdays_match
>> equals ~0 before doing the localtime calculations.
>>     
>
> Certainly.
>
>   

Thanks.