Re: xt_time 2007-09-22

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Sep 23 2007 17:05, Patrick McHardy wrote:
> 
>>>+	localtime_2(&current_time, stamp);
>>>+
>>>+	if (!(info->weekdays_match & (1 << current_time.weekday)))
>>>+		return false;
>>
>>Shouldn't this do the same optimization as below?
> 
> 
> No, it's not worth it. localtime_3 requires that localtime_2 be run
> before, so it would look like:
> 
> if (info->weekdays_match != XT_TIME_ALL_WEEKDAYS &&
>     info->monthdays_match != XT_TIME_ALL_MONTHDAYS) {
> 	localtime_2(&current_time, stamp);
> 	if (!(info->weekdays_match & (1 << current_time.weekday)))
> 		return false;
> 	if (info->monthdays_match != XT_TIME_ALL_MONTHDAYS) {
> 		localtime_3(&current_time, stamp);
> 		if (!(info->monthdays_match & (1 << current_time.monthday)))
> 			return false;
> 	}
> }
> 
> Since localtime_2() is miniscule, all this if'ing does not improve
> things at all.


OK, thanks for the explanation.