All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Campedelli <lorenzo.campedelli@tele2.it>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] vvfat mbr fixes
Date: Sun, 23 Sep 2007 22:17:42 +0200	[thread overview]
Message-ID: <46F6C9E6.8080503@tele2.it> (raw)
In-Reply-To: <Pine.LNX.4.64.0709232017280.28395@racer.site>

Johannes Schindelin wrote:
> Hi,
> 
> On Sun, 23 Sep 2007, Lorenzo Campedelli wrote:
> 
>> I was concerned by having this handling outside of a proper place (i.e. 
>> block-vvfat.c), but if we want to leave it there, wouldn't it be better 
>> to just handle cases which would otherwise fail, and just try to fix the 
>> "fat:" format?
> 
> I don't like that option, since it special-cases vvfat to much.
> 
> Ciao,
> Dscho
> 
> 
> 
> 
I agree the fix is ugly, otoh the problem is also a special case...
I don't see a clean way of fixing this, the code in block.c needs to 
know how to handle a vvfat specific filename format.

I'll keep my "works for me" patch waiting for some better fix.

Thanks for your time.
Lorenzo

  reply	other threads:[~2007-09-23 20:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-22 21:43 [Qemu-devel] [PATCH] vvfat mbr fixes Ivan Kalvachev
2007-09-22 22:48 ` Johannes Schindelin
2007-09-23  7:31   ` [Qemu-devel] " Lorenzo Campedelli
2007-09-23 11:34     ` Johannes Schindelin
2007-09-23 15:55       ` Lorenzo Campedelli
2007-09-23 19:18         ` Johannes Schindelin
2007-09-23 20:17           ` Lorenzo Campedelli [this message]
2007-09-24 10:50   ` [Qemu-devel] " Ivan Kalvachev
2007-09-24 11:18     ` Johannes Schindelin
2007-09-24 14:12       ` Ivan Kalvachev
2007-09-24 15:32         ` Johannes Schindelin
2007-09-24 17:23           ` Ivan Kalvachev
2007-09-24 19:19           ` [Qemu-devel] " Lorenzo Campedelli
2007-09-24 21:58             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F6C9E6.8080503@tele2.it \
    --to=lorenzo.campedelli@tele2.it \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.