Old libselinux bug. We are leaking a file descriptor.

Old libselinux bug. We are leaking a file descriptor.

[Daniel J Walsh]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This bug causes dbus to leak file descriptors when autostarting confined
applications.

Should be able to remove

	ifdef(`hide_broken_symptoms', `
		dontaudit $2 $1_dbusd_t:netlink_selinux_socket { read write };
	');

- From policy.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFG99qorlYvE4MpobMRAhGxAKDFGatnSzGeXfzRq2feuXR/NPlr3wCgx7CV
iam5zavHRuXTKFGXP9QJbdI=
=cILD
-----END PGP SIGNATURE-----

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 422 bytes --]

diff --exclude-from=exclude -N -u -r nsalibselinux/src/avc_internal.c libselinux-2.0.34/src/avc_internal.c
--- nsalibselinux/src/avc_internal.c	2007-07-16 14:20:46.000000000 -0400
+++ libselinux-2.0.34/src/avc_internal.c	2007-09-24 11:37:47.000000000 -0400
@@ -61,7 +61,8 @@
 		rc = fd;
 		goto out;
 	}
-
+	
+	fcntl(fd, F_SETFD, FD_CLOEXEC);
 	if (!blocking && fcntl(fd, F_SETFL, O_NONBLOCK)) {
 		close(fd);
 		rc = -1;

[-- Attachment #3: diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: Old libselinux bug. We are leaking a file descriptor.

[Stephen Smalley]

On Mon, 2007-09-24 at 11:41 -0400, Daniel J Walsh wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> This bug causes dbus to leak file descriptors when autostarting confined
> applications.
> 
> Should be able to remove
> 
> 	ifdef(`hide_broken_symptoms', `
> 		dontaudit $2 $1_dbusd_t:netlink_selinux_socket { read write };
> 	');
> 
> - From policy.

Applied.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.