From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: "David Gibson" <david@gibson.dropbear.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH v2] powerpc/xive: Fix bogus error code returned by OPAL
Date: Thu, 19 Sep 2019 20:26:00 +1000 (AEST) [thread overview]
Message-ID: <46YtKj1yP9z9sQw@ozlabs.org> (raw)
In-Reply-To: <156821713818.1985334.14123187368108582810.stgit@bahia.lan>
On Wed, 2019-09-11 at 15:52:18 UTC, Greg Kurz wrote:
> There's a bug in skiboot that causes the OPAL_XIVE_ALLOCATE_IRQ call
> to return the 32-bit value 0xffffffff when OPAL has run out of IRQs.
> Unfortunatelty, OPAL return values are signed 64-bit entities and
> errors are supposed to be negative. If that happens, the linux code
> confusingly treats 0xffffffff as a valid IRQ number and panics at some
> point.
>
> A fix was recently merged in skiboot:
>
> e97391ae2bb5 ("xive: fix return value of opal_xive_allocate_irq()")
>
> but we need a workaround anyway to support older skiboots already
> in the field.
>
> Internally convert 0xffffffff to OPAL_RESOURCE which is the usual error
> returned upon resource exhaustion.
>
> Cc: stable@vger.kernel.org # v4.12+
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6ccb4ac2bf8a35c694ead92f8ac5530a16e8f2c8
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2] powerpc/xive: Fix bogus error code returned by OPAL
Date: Thu, 19 Sep 2019 20:26:00 +1000 (AEST) [thread overview]
Message-ID: <46YtKj1yP9z9sQw@ozlabs.org> (raw)
In-Reply-To: <156821713818.1985334.14123187368108582810.stgit@bahia.lan>
On Wed, 2019-09-11 at 15:52:18 UTC, Greg Kurz wrote:
> There's a bug in skiboot that causes the OPAL_XIVE_ALLOCATE_IRQ call
> to return the 32-bit value 0xffffffff when OPAL has run out of IRQs.
> Unfortunatelty, OPAL return values are signed 64-bit entities and
> errors are supposed to be negative. If that happens, the linux code
> confusingly treats 0xffffffff as a valid IRQ number and panics at some
> point.
>
> A fix was recently merged in skiboot:
>
> e97391ae2bb5 ("xive: fix return value of opal_xive_allocate_irq()")
>
> but we need a workaround anyway to support older skiboots already
> in the field.
>
> Internally convert 0xffffffff to OPAL_RESOURCE which is the usual error
> returned upon resource exhaustion.
>
> Cc: stable@vger.kernel.org # v4.12+
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6ccb4ac2bf8a35c694ead92f8ac5530a16e8f2c8
cheers
next prev parent reply other threads:[~2019-09-19 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:52 [PATCH v2] powerpc/xive: Fix bogus error code returned by OPAL Greg Kurz
2019-09-11 15:52 ` Greg Kurz
2019-09-11 16:02 ` Cédric Le Goater
2019-09-11 16:02 ` Cédric Le Goater
[not found] ` <20190912073049.CF36B20830@mail.kernel.org>
2019-09-13 11:12 ` Greg Kurz
2019-09-17 4:09 ` Michael Ellerman
2019-09-17 5:06 ` Greg KH
2019-09-17 6:13 ` Greg Kurz
2019-09-19 10:26 ` Michael Ellerman [this message]
2019-09-19 10:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46YtKj1yP9z9sQw@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.