From: Mats Petersson <mats@planetcatfish.com>
To: Kieran Mansley <kmansley@solarflare.com>,
"Zhao, Yunfeng" <yunfeng.zhao@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: compile error of HVM pv drivers
Date: Mon, 30 Jul 2007 11:13:43 +0100 [thread overview]
Message-ID: <46adb9f6.2283420a.5ce4.1839@mx.google.com> (raw)
In-Reply-To: <1185789517.4287.10.camel@moonstone.uk.level5networks.com>
At 10:58 30/07/2007, Kieran Mansley wrote:
>On Mon, 2007-07-30 at 17:28 +0800, Zhao, Yunfeng wrote:
> > With gcc 3.4.2 I got following errors while compiling HVM pv drivers
> > against xen unstable 15651.
> > #################
> > /xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6
> > /netfront/accel.c: In function `accelerator_remove_hooks':
> > xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6/
> > netfront/accel.c:495: error: syntax error before "do"
> > xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6/
> > netfront/accel.c:495: error: syntax error before ')' token
> > ###################
> > But on rhel5 (gcc 4.1.1), the build can pass without any error.
>
>Curious. Can you post what code you have at that line. In my recent
>checkout it looks like this:
>
>490: list_for_each_entry_safe(vif_state, tmp,
>491: &accelerator->vif_states,
>492: link) {
>493: /* Make sure there are no data path operations going on */
>494: netif_poll_disable(vif_state->np->netdev);
>495: netif_tx_lock_bh(vif_state->np->netdev);
Unless one of those lines is a macro that uses the "do { ... }
while(0)" trick, perhaps - how about looking at the preprocessor
output for those lines?
--
Mats
>Which doesn't seem to match the error you're getting. No "do" for
>example.
>
>I'll try and reproduce it, but haven't seen this before, and the nearest
>gcc version I have easily to hand is 3.4.3
>
>Kieran
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2007-07-30 10:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 9:28 compile error of HVM pv drivers Zhao, Yunfeng
2007-07-30 9:52 ` Keir Fraser
2007-07-30 9:58 ` Kieran Mansley
2007-07-30 10:13 ` Mats Petersson [this message]
2007-07-30 12:43 ` Zhao, Yunfeng
2007-07-30 13:42 ` Kieran Mansley
2007-07-30 13:49 ` Zhao, Yunfeng
2007-07-30 14:05 ` Kieran Mansley
2007-07-30 14:15 ` Zhao, Yunfeng
2007-07-30 14:22 ` Zhao, Yunfeng
2007-07-30 14:24 ` Kieran Mansley
2007-07-30 14:32 ` Zhao, Yunfeng
2007-07-30 14:39 ` Zhao, Yunfeng
2007-07-30 14:42 ` Keir Fraser
2007-07-30 14:47 ` Kieran Mansley
2007-07-30 14:51 ` Keir Fraser
2007-07-30 15:02 ` Zhao, Yunfeng
2007-07-30 15:05 ` Keir Fraser
2007-07-30 15:38 ` Zhao, Yunfeng
2007-07-30 15:42 ` Kieran Mansley
2007-07-30 16:42 ` Keir Fraser
2007-07-30 14:54 ` Kieran Mansley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46adb9f6.2283420a.5ce4.1839@mx.google.com \
--to=mats@planetcatfish.com \
--cc=kmansley@solarflare.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunfeng.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.