All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Chukun Pan <amadeus@jmu.edu.cn>, Yixun Lan <dlan@kernel.org>
Cc: michael.opdenacker@rootcommit.com, Rob Herring <robh@kernel.org>,
	Paul Walmsley <pjw@kernel.org>, Alexandre Ghiti <alex@ghiti.fr>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v2 2/3] riscv: dts: spacemit: enable USB3 on OrangePi R2S
Date: Thu,  2 Apr 2026 14:24:52 +0000 (UTC)	[thread overview]
Message-ID: <46e715a4-0fd7-4692-9a25-a44d469b17b0@rootcommit.com> (raw)
In-Reply-To: <20260402100007.110201-3-amadeus@jmu.edu.cn>

Hi Chukun

On 4/2/26 12:00 PM, Chukun Pan wrote:
> Enable the DWC3 USB3.0 controller and its associated PHY on the
> OrangePi R2S. The USB regulator provides VBUS for USB2 and USB3
> ports, but the USB2 ports are handled by a separate controller.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 24 +++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> index 409a6db269ae..bc68721e6263 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> @@ -40,6 +40,20 @@ vcc4v0: regulator-vcc4v0 {
>   		regulator-max-microvolt = <4000000>;
>   		vin-supply = <&vcc_5v0>;
>   	};
> +
> +	vcc5v0_usb: regulator-vcc5v0-usb {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpios = <&gpio K1_GPIO(126) GPIO_ACTIVE_HIGH>;
> +		regulator-name = "vcc5v0_usb";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&vcc_5v0>;
> +	};
> +};
> +
> +&combo_phy {
> +	status = "okay";
>   };
>   
>   &emmc {
> @@ -109,3 +123,13 @@ &uart0 {
>   	pinctrl-0 = <&uart0_2_cfg>;
>   	status = "okay";
>   };
> +
> +&usbphy2 {
> +	status = "okay";
> +};
> +
> +&usb_dwc3 {
> +	dr_mode = "host";
> +	vbus-supply = <&vcc5v0_usb>;
> +	status = "okay";
> +};


Thanks a lot for the patch!
Would you mind sharing your configuration with me (in PM?).

I can list the USB 3 hub, but I can't see the USB mass storage device 
plugged in the USB3 port.

# lsusb
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub

Thanks in advance
Cheers
Michael.

-- 
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com


WARNING: multiple messages have this Message-ID (diff)
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Chukun Pan <amadeus@jmu.edu.cn>, Yixun Lan <dlan@kernel.org>
Cc: michael.opdenacker@rootcommit.com, Rob Herring <robh@kernel.org>,
	Paul Walmsley <pjw@kernel.org>, Alexandre Ghiti <alex@ghiti.fr>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v2 2/3] riscv: dts: spacemit: enable USB3 on OrangePi R2S
Date: Thu,  2 Apr 2026 14:24:52 +0000 (UTC)	[thread overview]
Message-ID: <46e715a4-0fd7-4692-9a25-a44d469b17b0@rootcommit.com> (raw)
In-Reply-To: <20260402100007.110201-3-amadeus@jmu.edu.cn>

Hi Chukun

On 4/2/26 12:00 PM, Chukun Pan wrote:
> Enable the DWC3 USB3.0 controller and its associated PHY on the
> OrangePi R2S. The USB regulator provides VBUS for USB2 and USB3
> ports, but the USB2 ports are handled by a separate controller.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 24 +++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> index 409a6db269ae..bc68721e6263 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> @@ -40,6 +40,20 @@ vcc4v0: regulator-vcc4v0 {
>   		regulator-max-microvolt = <4000000>;
>   		vin-supply = <&vcc_5v0>;
>   	};
> +
> +	vcc5v0_usb: regulator-vcc5v0-usb {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpios = <&gpio K1_GPIO(126) GPIO_ACTIVE_HIGH>;
> +		regulator-name = "vcc5v0_usb";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&vcc_5v0>;
> +	};
> +};
> +
> +&combo_phy {
> +	status = "okay";
>   };
>   
>   &emmc {
> @@ -109,3 +123,13 @@ &uart0 {
>   	pinctrl-0 = <&uart0_2_cfg>;
>   	status = "okay";
>   };
> +
> +&usbphy2 {
> +	status = "okay";
> +};
> +
> +&usb_dwc3 {
> +	dr_mode = "host";
> +	vbus-supply = <&vcc5v0_usb>;
> +	status = "okay";
> +};


Thanks a lot for the patch!
Would you mind sharing your configuration with me (in PM?).

I can list the USB 3 hub, but I can't see the USB mass storage device 
plugged in the USB3 port.

# lsusb
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub

Thanks in advance
Cheers
Michael.

-- 
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-04-02 14:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 10:00 [PATCH v2 0/3] riscv: dts: spacemit: enable USB3 on OrangePi Chukun Pan
2026-04-02 10:00 ` Chukun Pan
2026-04-02 10:00 ` [PATCH v2 1/3] riscv: dts: spacemit: add fixed regulators for OrangePi Chukun Pan
2026-04-02 10:00   ` Chukun Pan
2026-04-02 10:00 ` [PATCH v2 2/3] riscv: dts: spacemit: enable USB3 on OrangePi R2S Chukun Pan
2026-04-02 10:00   ` Chukun Pan
2026-04-02 14:24   ` Michael Opdenacker [this message]
2026-04-02 14:24     ` Michael Opdenacker
2026-04-03  7:00     ` Chukun Pan
2026-04-03  7:00       ` Chukun Pan
2026-04-02 10:00 ` [PATCH v2 3/3] riscv: dts: spacemit: enable USB3 on OrangePi RV2 Chukun Pan
2026-04-02 10:00   ` Chukun Pan
2026-04-02 12:20   ` Yixun Lan
2026-04-02 12:20     ` Yixun Lan
2026-04-02 13:06     ` Chukun Pan
2026-04-02 13:06       ` Chukun Pan
2026-04-03  0:16       ` Yixun Lan
2026-04-03  0:16         ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46e715a4-0fd7-4692-9a25-a44d469b17b0@rootcommit.com \
    --to=michael.opdenacker@rootcommit.com \
    --cc=alex@ghiti.fr \
    --cc=amadeus@jmu.edu.cn \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.