From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: matthew@wil.cx, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: slave_configure for qlogicpti
Date: Mon, 01 Oct 2007 08:22:07 -0400 [thread overview]
Message-ID: <4700E66F.40808@garzik.org> (raw)
In-Reply-To: <20070930.182412.08350831.davem@davemloft.net>
David Miller wrote:
> From: Jeff Garzik <jeff@garzik.org>
> Date: Sun, 30 Sep 2007 20:52:45 -0400
>
>> David Miller wrote:
>>> It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
>>> so you can kill those off too.
>>
>> Seeing as how they are exact duplicates of libata's
>> ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place
>> (rather than becoming common code), and I wonder how many more copies
>> are floating out there...
>
> I bet: 1) they were common code in scsi_lib.c 2) qlogicpti and libata
> became the only remaining users so 3) they got copied to those
> two users verbatim anticipating that the qlogicpti usage would
> eventually be deleted.
I wrote the libata code from scratch, so I was just sorta curious. No
biggie either (read: I'm too lazy to search the history).
After the qlogicpti use goes away, libata-scsi is the remaining user of
that logic. The code is already local to libata, so... all good.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: matthew@wil.cx, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: slave_configure for qlogicpti
Date: Mon, 01 Oct 2007 12:22:07 +0000 [thread overview]
Message-ID: <4700E66F.40808@garzik.org> (raw)
In-Reply-To: <20070930.182412.08350831.davem@davemloft.net>
David Miller wrote:
> From: Jeff Garzik <jeff@garzik.org>
> Date: Sun, 30 Sep 2007 20:52:45 -0400
>
>> David Miller wrote:
>>> It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
>>> so you can kill those off too.
>>
>> Seeing as how they are exact duplicates of libata's
>> ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place
>> (rather than becoming common code), and I wonder how many more copies
>> are floating out there...
>
> I bet: 1) they were common code in scsi_lib.c 2) qlogicpti and libata
> became the only remaining users so 3) they got copied to those
> two users verbatim anticipating that the qlogicpti usage would
> eventually be deleted.
I wrote the libata code from scratch, so I was just sorta curious. No
biggie either (read: I'm too lazy to search the history).
After the qlogicpti use goes away, libata-scsi is the remaining user of
that logic. The code is already local to libata, so... all good.
Jeff
next prev parent reply other threads:[~2007-10-01 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 12:46 slave_configure for qlogicpti Matthew Wilcox
2007-09-19 12:46 ` Matthew Wilcox
2007-10-01 0:29 ` David Miller
2007-10-01 0:29 ` David Miller
2007-10-01 0:52 ` Jeff Garzik
2007-10-01 0:52 ` Jeff Garzik
2007-10-01 1:24 ` David Miller
2007-10-01 1:24 ` David Miller
2007-10-01 12:22 ` Jeff Garzik [this message]
2007-10-01 12:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4700E66F.40808@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.