From: Takenori Nagano <t-nagano@ah.jp.nec.com>
To: vgoyal@in.ibm.com
Cc: k-miyoshi@cb.jp.nec.com, Bernhard Walle <bwalle@suse.de>,
kdb@oss.sgi.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Keith Owens <kaos@ocs.com.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] add tunable_notifier function
Date: Fri, 05 Oct 2007 14:49:36 +0900 [thread overview]
Message-ID: <4705D070.7080403@ah.jp.nec.com> (raw)
In-Reply-To: <20071005054205.GB4893@in.ibm.com>
Vivek Goyal wrote:
> On Thu, Oct 04, 2007 at 08:38:34PM +0900, Takenori Nagano wrote:
>> This patch adds new notifier function tunable_notifier_chain. Its base is
>> atomic_notifier_chain.
>>
>> Thanks,
>>
>> ---
>>
>> Signed-off-by: Takenori Nagano <t-nagano@ah.jp.nec.com>
>>
>> ---
>> diff -uprN linux-2.6.23-rc9.orig/include/linux/notifier.h
>> linux-2.6.23-rc9/include/linux/notifier.h
>> --- linux-2.6.23-rc9.orig/include/linux/notifier.h 2007-10-02 12:24:52.000000000
>> +0900
>> +++ linux-2.6.23-rc9/include/linux/notifier.h 2007-10-03 14:48:04.288000000 +0900
>> @@ -13,6 +13,7 @@
>> #include <linux/mutex.h>
>> #include <linux/rwsem.h>
>> #include <linux/srcu.h>
>> +#include <linux/kobject.h>
>>
>> /*
>> * Notifier chains are of four types:
>> @@ -53,6 +54,14 @@ struct notifier_block {
>> int priority;
>> };
>>
>> +struct tunable_notifier_block {
>> + struct notifier_block *nb;
>> + struct tunable_notifier_head *head;
>> + struct dentry *dir;
>> + struct dentry *pri_dentry;
>> + struct dentry *desc_dentry;
>> +};
>> +
>
> Should this be tunable_atomic_notifier_block? I think there are two kind
> of lists. One where handlers have to be atomic and other one where handlers
> can be blocking one. I think you are making atomic one tunable. If that's
> the case it should be reflected in the naming everywhere.
Hi Vivek,
Yes, it based on atomic_notifier_list. I think your opinion is reasonable.
I'll change the name tunable_notifier to tunable_atomic_notifier.
Thanks,
Takenori Nagano <t-nagano@ah.jp.nec.com>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Takenori Nagano <t-nagano@ah.jp.nec.com>
To: vgoyal@in.ibm.com
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
k-miyoshi@cb.jp.nec.com, kexec@lists.infradead.org,
Bernhard Walle <bwalle@suse.de>, Keith Owens <kaos@ocs.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
kdb@oss.sgi.com
Subject: Re: [PATCH 1/2] add tunable_notifier function
Date: Fri, 05 Oct 2007 14:49:36 +0900 [thread overview]
Message-ID: <4705D070.7080403@ah.jp.nec.com> (raw)
In-Reply-To: <20071005054205.GB4893@in.ibm.com>
Vivek Goyal wrote:
> On Thu, Oct 04, 2007 at 08:38:34PM +0900, Takenori Nagano wrote:
>> This patch adds new notifier function tunable_notifier_chain. Its base is
>> atomic_notifier_chain.
>>
>> Thanks,
>>
>> ---
>>
>> Signed-off-by: Takenori Nagano <t-nagano@ah.jp.nec.com>
>>
>> ---
>> diff -uprN linux-2.6.23-rc9.orig/include/linux/notifier.h
>> linux-2.6.23-rc9/include/linux/notifier.h
>> --- linux-2.6.23-rc9.orig/include/linux/notifier.h 2007-10-02 12:24:52.000000000
>> +0900
>> +++ linux-2.6.23-rc9/include/linux/notifier.h 2007-10-03 14:48:04.288000000 +0900
>> @@ -13,6 +13,7 @@
>> #include <linux/mutex.h>
>> #include <linux/rwsem.h>
>> #include <linux/srcu.h>
>> +#include <linux/kobject.h>
>>
>> /*
>> * Notifier chains are of four types:
>> @@ -53,6 +54,14 @@ struct notifier_block {
>> int priority;
>> };
>>
>> +struct tunable_notifier_block {
>> + struct notifier_block *nb;
>> + struct tunable_notifier_head *head;
>> + struct dentry *dir;
>> + struct dentry *pri_dentry;
>> + struct dentry *desc_dentry;
>> +};
>> +
>
> Should this be tunable_atomic_notifier_block? I think there are two kind
> of lists. One where handlers have to be atomic and other one where handlers
> can be blocking one. I think you are making atomic one tunable. If that's
> the case it should be reflected in the naming everywhere.
Hi Vivek,
Yes, it based on atomic_notifier_list. I think your opinion is reasonable.
I'll change the name tunable_notifier to tunable_atomic_notifier.
Thanks,
Takenori Nagano <t-nagano@ah.jp.nec.com>
next prev parent reply other threads:[~2007-10-05 5:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 11:38 [PATCH 1/2] add tunable_notifier function Takenori Nagano
2007-10-04 11:38 ` Takenori Nagano
2007-10-04 16:11 ` Randy Dunlap
2007-10-04 16:11 ` Randy Dunlap
2007-10-05 5:06 ` Takenori Nagano
2007-10-05 5:06 ` Takenori Nagano
2007-10-05 5:42 ` Vivek Goyal
2007-10-05 5:42 ` Vivek Goyal
2007-10-05 5:49 ` Takenori Nagano [this message]
2007-10-05 5:49 ` Takenori Nagano
2007-10-05 12:49 ` Eric W. Biederman
2007-10-05 12:49 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4705D070.7080403@ah.jp.nec.com \
--to=t-nagano@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=bwalle@suse.de \
--cc=ebiederm@xmission.com \
--cc=k-miyoshi@cb.jp.nec.com \
--cc=kaos@ocs.com.au \
--cc=kdb@oss.sgi.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.