All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takenori Nagano <t-nagano@ah.jp.nec.com>
To: vgoyal@in.ibm.com
Cc: k-miyoshi@cb.jp.nec.com, Bernhard Walle <bwalle@suse.de>,
	kdb@oss.sgi.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Keith Owens <kaos@ocs.com.au>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] implement new notifier function to panic_notifier_list
Date: Fri, 05 Oct 2007 15:19:42 +0900	[thread overview]
Message-ID: <4705D77E.5000703@ah.jp.nec.com> (raw)
In-Reply-To: <20071005054952.GC4893@in.ibm.com>

Vivek Goyal wrote:
> On Thu, Oct 04, 2007 at 08:38:50PM +0900, Takenori Nagano wrote:
>
>> @@ -522,8 +530,8 @@ setup_arch(char **cmdline_p)
>>  	}
>>
>>  	/* Register a call for panic conditions. */
>> -	atomic_notifier_chain_register(&panic_notifier_list,
>> -			&alpha_panic_block);
>> +	tunable_notifier_chain_register(&panic_notifier_list,
>> +			&alpha_panic_block, "alpha_panic", NULL);
>>
> 
> I think it might be good idea to somehow create provisions for another a
> help string. This help string will inform admin that what a registered
> user does? Ideally this should be visible in /sys/kernel/debug/<user module>/description file.

Hi Vivek,

We can make description file with tunable_notifier_chain_register 4th argument.
If developer sets 4th argument, tunable_notifier_chain_register makes
/sys/kernel/debug/<name>/description file. Admin can get information from the
description file.

+/**
+ *	tunable_notifier_chain_register - Add notifier to an tunable notifier chain
+ *	@nh: Pointer to head of the tunable notifier chain
+ *	@n: New entry in notifier chain
+ *	@name: Pointer to the name of the new notifier entry
+ *	@desc: Pointer to the description of new entry
+ *
+ *	Adds a notifier to an tunable notifier chain and makes control dir.
+ *
+ *	Returns zero on success or %-ENODEV on failure.
+ */

Thanks,

Takenori Nagano <t-nagano@ah.jp.nec.com>

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Takenori Nagano <t-nagano@ah.jp.nec.com>
To: vgoyal@in.ibm.com
Cc: linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	k-miyoshi@cb.jp.nec.com, kexec@lists.infradead.org,
	Bernhard Walle <bwalle@suse.de>, Keith Owens <kaos@ocs.com.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	kdb@oss.sgi.com
Subject: Re: [PATCH 2/2] implement new notifier function to panic_notifier_list
Date: Fri, 05 Oct 2007 15:19:42 +0900	[thread overview]
Message-ID: <4705D77E.5000703@ah.jp.nec.com> (raw)
In-Reply-To: <20071005054952.GC4893@in.ibm.com>

Vivek Goyal wrote:
> On Thu, Oct 04, 2007 at 08:38:50PM +0900, Takenori Nagano wrote:
>
>> @@ -522,8 +530,8 @@ setup_arch(char **cmdline_p)
>>  	}
>>
>>  	/* Register a call for panic conditions. */
>> -	atomic_notifier_chain_register(&panic_notifier_list,
>> -			&alpha_panic_block);
>> +	tunable_notifier_chain_register(&panic_notifier_list,
>> +			&alpha_panic_block, "alpha_panic", NULL);
>>
> 
> I think it might be good idea to somehow create provisions for another a
> help string. This help string will inform admin that what a registered
> user does? Ideally this should be visible in /sys/kernel/debug/<user module>/description file.

Hi Vivek,

We can make description file with tunable_notifier_chain_register 4th argument.
If developer sets 4th argument, tunable_notifier_chain_register makes
/sys/kernel/debug/<name>/description file. Admin can get information from the
description file.

+/**
+ *	tunable_notifier_chain_register - Add notifier to an tunable notifier chain
+ *	@nh: Pointer to head of the tunable notifier chain
+ *	@n: New entry in notifier chain
+ *	@name: Pointer to the name of the new notifier entry
+ *	@desc: Pointer to the description of new entry
+ *
+ *	Adds a notifier to an tunable notifier chain and makes control dir.
+ *
+ *	Returns zero on success or %-ENODEV on failure.
+ */

Thanks,

Takenori Nagano <t-nagano@ah.jp.nec.com>

  reply	other threads:[~2007-10-05  6:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-04 11:38 [PATCH 2/2] implement new notifier function to panic_notifier_list Takenori Nagano
2007-10-04 11:38 ` Takenori Nagano
2007-10-04 16:07 ` Randy Dunlap
2007-10-04 16:07   ` Randy Dunlap
2007-10-05  4:59   ` Takenori Nagano
2007-10-05  4:59     ` Takenori Nagano
2007-10-05  5:49 ` Vivek Goyal
2007-10-05  5:49   ` Vivek Goyal
2007-10-05  6:19   ` Takenori Nagano [this message]
2007-10-05  6:19     ` Takenori Nagano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4705D77E.5000703@ah.jp.nec.com \
    --to=t-nagano@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=bwalle@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=k-miyoshi@cb.jp.nec.com \
    --cc=kaos@ocs.com.au \
    --cc=kdb@oss.sgi.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.