* Re: [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups
2007-08-29 10:19 [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups Jean Delvare
@ 2007-10-05 7:27 ` Hans de Goede
2007-10-05 9:48 ` Jean Delvare
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2007-10-05 7:27 UTC (permalink / raw)
To: lm-sensors
Hi All,
In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html
Jean Delvare wrote:
--------------------------------------------
* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is
now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are
custom chips which can only be found on their respective manufacturer's
systems, and these manufacturers only do x86 hardware AFAIK.
Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
drivers/hwmon/Kconfig | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--- linux-2.6.23-rc4.orig/drivers/hwmon/Kconfig 2007-08-29 12:10:56.000000000 +0200
+++ linux-2.6.23-rc4/drivers/hwmon/Kconfig 2007-08-29 12:11:51.000000000 +0200
@@ -30,7 +30,7 @@ config HWMON_VID
config SENSORS_ABITUGURU
tristate "Abit uGuru (rev 1 & 2)"
- depends on EXPERIMENTAL
+ depends on X86 && EXPERIMENTAL
help
If you say yes here you get support for the sensor part of the first
and second revision of the Abit uGuru chip. The voltage and frequency
@@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
config SENSORS_ABITUGURU3
tristate "Abit uGuru (rev 3)"
- depends on HWMON && EXPERIMENTAL
+ depends on X86 && EXPERIMENTAL
help
If you say yes here you get support for the sensor part of the
third revision of the Abit uGuru chip. Only reading the sensors
@@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
config SENSORS_ASB100
tristate "Asus ASB100 Bach"
- depends on I2C && EXPERIMENTAL
+ depends on X86 && I2C && EXPERIMENTAL
select HWMON_VID
help
If you say yes here you get support for the ASB100 Bach sensor
@@ -248,7 +248,7 @@ config SENSORS_F75375S
config SENSORS_FSCHER
tristate "FSC Hermes"
- depends on I2C
+ depends on X86 && I2C
help
If you say yes here you get support for Fujitsu Siemens
Computers Hermes sensor chips.
@@ -258,7 +258,7 @@ config SENSORS_FSCHER
config SENSORS_FSCPOS
tristate "FSC Poseidon"
- depends on I2C
+ depends on X86 && I2C
help
If you say yes here you get support for Fujitsu Siemens
Computers Poseidon sensor chips.
@@ -431,7 +431,7 @@ config SENSORS_LM92
config SENSORS_LM93
tristate "National Semiconductor LM93 and compatibles"
- depends on HWMON && I2C
+ depends on I2C
select HWMON_VID
help
If you say yes here you get support for National Semiconductor LM93
--
Jean Delvare
-------------------------------------------------------------
One beginner question, does X86 also get defined on x86_64? If not this won't work.
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups
2007-08-29 10:19 [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups Jean Delvare
2007-10-05 7:27 ` Hans de Goede
@ 2007-10-05 9:48 ` Jean Delvare
2007-10-06 6:36 ` Hans de Goede
2007-10-06 19:33 ` Mark M. Hoffman
3 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2007-10-05 9:48 UTC (permalink / raw)
To: lm-sensors
Hi Hans,
On Fri, 05 Oct 2007 09:27:14 +0200, Hans de Goede wrote:
> In this post:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html
>
> Jean Delvare wrote:
> --------------------------------------------
> * Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is
> now handled at menu level.
> * Make the Abit, Asus and FSC chip drivers depend on X86. These are
> custom chips which can only be found on their respective manufacturer's
> systems, and these manufacturers only do x86 hardware AFAIK.
>
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> ---
> drivers/hwmon/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.23-rc4.orig/drivers/hwmon/Kconfig 2007-08-29 12:10:56.000000000 +0200
> +++ linux-2.6.23-rc4/drivers/hwmon/Kconfig 2007-08-29 12:11:51.000000000 +0200
> @@ -30,7 +30,7 @@ config HWMON_VID
>
> config SENSORS_ABITUGURU
> tristate "Abit uGuru (rev 1 & 2)"
> - depends on EXPERIMENTAL
> + depends on X86 && EXPERIMENTAL
> help
> If you say yes here you get support for the sensor part of the first
> and second revision of the Abit uGuru chip. The voltage and frequency
> @@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
>
> config SENSORS_ABITUGURU3
> tristate "Abit uGuru (rev 3)"
> - depends on HWMON && EXPERIMENTAL
> + depends on X86 && EXPERIMENTAL
> help
> If you say yes here you get support for the sensor part of the
> third revision of the Abit uGuru chip. Only reading the sensors
> @@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
>
> config SENSORS_ASB100
> tristate "Asus ASB100 Bach"
> - depends on I2C && EXPERIMENTAL
> + depends on X86 && I2C && EXPERIMENTAL
> select HWMON_VID
> help
> If you say yes here you get support for the ASB100 Bach sensor
> @@ -248,7 +248,7 @@ config SENSORS_F75375S
>
> config SENSORS_FSCHER
> tristate "FSC Hermes"
> - depends on I2C
> + depends on X86 && I2C
> help
> If you say yes here you get support for Fujitsu Siemens
> Computers Hermes sensor chips.
> @@ -258,7 +258,7 @@ config SENSORS_FSCHER
>
> config SENSORS_FSCPOS
> tristate "FSC Poseidon"
> - depends on I2C
> + depends on X86 && I2C
> help
> If you say yes here you get support for Fujitsu Siemens
> Computers Poseidon sensor chips.
> @@ -431,7 +431,7 @@ config SENSORS_LM92
>
> config SENSORS_LM93
> tristate "National Semiconductor LM93 and compatibles"
> - depends on HWMON && I2C
> + depends on I2C
> select HWMON_VID
> help
> If you say yes here you get support for National Semiconductor LM93
>
> -------------------------------------------------------------
>
> One beginner question, does X86 also get defined on x86_64? If not this won't work.
Yes, it does get defined. i386 gets X86 and X86_32, x86_64 gets X86 and
X86_64.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups
2007-08-29 10:19 [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups Jean Delvare
2007-10-05 7:27 ` Hans de Goede
2007-10-05 9:48 ` Jean Delvare
@ 2007-10-06 6:36 ` Hans de Goede
2007-10-06 19:33 ` Mark M. Hoffman
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2007-10-06 6:36 UTC (permalink / raw)
To: lm-sensors
Hi All,
In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html
Jean Delvare wrote:
--------------------------------------------
* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is
now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are
custom chips which can only be found on their respective manufacturer's
systems, and these manufacturers only do x86 hardware AFAIK.
Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
drivers/hwmon/Kconfig | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--- linux-2.6.23-rc4.orig/drivers/hwmon/Kconfig 2007-08-29 12:10:56.000000000 +0200
+++ linux-2.6.23-rc4/drivers/hwmon/Kconfig 2007-08-29 12:11:51.000000000 +0200
@@ -30,7 +30,7 @@ config HWMON_VID
config SENSORS_ABITUGURU
tristate "Abit uGuru (rev 1 & 2)"
- depends on EXPERIMENTAL
+ depends on X86 && EXPERIMENTAL
help
If you say yes here you get support for the sensor part of the first
and second revision of the Abit uGuru chip. The voltage and frequency
@@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
config SENSORS_ABITUGURU3
tristate "Abit uGuru (rev 3)"
- depends on HWMON && EXPERIMENTAL
+ depends on X86 && EXPERIMENTAL
help
If you say yes here you get support for the sensor part of the
third revision of the Abit uGuru chip. Only reading the sensors
@@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
config SENSORS_ASB100
tristate "Asus ASB100 Bach"
- depends on I2C && EXPERIMENTAL
+ depends on X86 && I2C && EXPERIMENTAL
select HWMON_VID
help
If you say yes here you get support for the ASB100 Bach sensor
@@ -248,7 +248,7 @@ config SENSORS_F75375S
config SENSORS_FSCHER
tristate "FSC Hermes"
- depends on I2C
+ depends on X86 && I2C
help
If you say yes here you get support for Fujitsu Siemens
Computers Hermes sensor chips.
@@ -258,7 +258,7 @@ config SENSORS_FSCHER
config SENSORS_FSCPOS
tristate "FSC Poseidon"
- depends on I2C
+ depends on X86 && I2C
help
If you say yes here you get support for Fujitsu Siemens
Computers Poseidon sensor chips.
@@ -431,7 +431,7 @@ config SENSORS_LM92
config SENSORS_LM93
tristate "National Semiconductor LM93 and compatibles"
- depends on HWMON && I2C
+ depends on I2C
select HWMON_VID
help
If you say yes here you get support for National Semiconductor LM93
-------------------------------------------------------------
Jean Delvare wrote:
> Hi Hans,
>
> On Fri, 05 Oct 2007 09:27:14 +0200, Hans de Goede wrote:
>> One beginner question, does X86 also get defined on x86_64? If not this
won't work.
>
> Yes, it does get defined. i386 gets X86 and X86_32, x86_64 gets X86 and
> X86_64.
>
In that case, its fine:
Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups
2007-08-29 10:19 [lm-sensors] [PATCH] hwmon: Kconfig dependency cleanups Jean Delvare
` (2 preceding siblings ...)
2007-10-06 6:36 ` Hans de Goede
@ 2007-10-06 19:33 ` Mark M. Hoffman
3 siblings, 0 replies; 5+ messages in thread
From: Mark M. Hoffman @ 2007-10-06 19:33 UTC (permalink / raw)
To: lm-sensors
Hi:
* Hans de Goede <j.w.r.degoede@hhs.nl> [2007-10-06 08:36:23 +0200]:
> Hi All,
>
> In this post:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html
>
> Jean Delvare wrote:
> --------------------------------------------
> * Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is
> now handled at menu level.
> * Make the Abit, Asus and FSC chip drivers depend on X86. These are
> custom chips which can only be found on their respective manufacturer's
> systems, and these manufacturers only do x86 hardware AFAIK.
>
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
(...)
> Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
Applied to hwmon-2.6.git/testing, thanks.
--
Mark M. Hoffman
mhoffman@lightlink.com
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread