From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/5] ARM: tegra: Add legacy interrupt controller nodes
Date: Thu, 28 Aug 2014 18:11:53 +0200 [thread overview]
Message-ID: <4707330.BNuO2MquVF@wuerfel> (raw)
In-Reply-To: <1409239879-12376-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thursday 28 August 2014 17:31:16 Thierry Reding wrote:
> + interrupt-controller@60004000 {
> + compatible = "nvidia,tegra114-ictlr", "nvidia,tegra30-ictlr";
> + reg = <0x60004000 0x40>, /* primary controller */
> + <0x60004100 0x40>, /* secondary controller */
> + <0x60004200 0x40>, /* tertiary controller */
> + <0x60004300 0x40>, /* quaternary controller */
> + <0x60004400 0x40>; /* quinary controller */
> + };
> +
> timer@60005000 {
> compatible = "nvidia,tegra114-timer", "nvidia,tegra20-timer";
>
Don't you need an interrupt-parent and interrupts property here to point to
the GIC interrupts? I would assume this is a nested irqchip.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/5] ARM: tegra: Add legacy interrupt controller nodes
Date: Thu, 28 Aug 2014 18:11:53 +0200 [thread overview]
Message-ID: <4707330.BNuO2MquVF@wuerfel> (raw)
In-Reply-To: <1409239879-12376-2-git-send-email-thierry.reding@gmail.com>
On Thursday 28 August 2014 17:31:16 Thierry Reding wrote:
> + interrupt-controller at 60004000 {
> + compatible = "nvidia,tegra114-ictlr", "nvidia,tegra30-ictlr";
> + reg = <0x60004000 0x40>, /* primary controller */
> + <0x60004100 0x40>, /* secondary controller */
> + <0x60004200 0x40>, /* tertiary controller */
> + <0x60004300 0x40>, /* quaternary controller */
> + <0x60004400 0x40>; /* quinary controller */
> + };
> +
> timer at 60005000 {
> compatible = "nvidia,tegra114-timer", "nvidia,tegra20-timer";
>
Don't you need an interrupt-parent and interrupts property here to point to
the GIC interrupts? I would assume this is a nested irqchip.
Arnd
next prev parent reply other threads:[~2014-08-28 16:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 15:31 [PATCH v4 1/5] of: Add NVIDIA Tegra Legacy Interrupt Controller binding Thierry Reding
2014-08-28 15:31 ` Thierry Reding
[not found] ` <1409239879-12376-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-28 15:31 ` [PATCH v4 2/5] ARM: tegra: Add legacy interrupt controller nodes Thierry Reding
2014-08-28 15:31 ` Thierry Reding
[not found] ` <1409239879-12376-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-28 16:11 ` Arnd Bergmann [this message]
2014-08-28 16:11 ` Arnd Bergmann
2014-09-01 8:16 ` Peter De Schrijver
2014-09-01 8:16 ` Peter De Schrijver
2014-08-28 15:31 ` [PATCH v4 3/5] ARM: tegra: Initialize interrupt controller from DT Thierry Reding
2014-08-28 15:31 ` Thierry Reding
[not found] ` <1409239879-12376-3-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-28 16:10 ` Arnd Bergmann
2014-08-28 16:10 ` Arnd Bergmann
2014-08-29 7:31 ` Thierry Reding
2014-08-29 7:31 ` Thierry Reding
2014-08-29 14:24 ` Thierry Reding
2014-08-29 14:24 ` Thierry Reding
2014-08-29 15:04 ` Thierry Reding
2014-08-29 15:04 ` Thierry Reding
2014-08-29 19:53 ` Arnd Bergmann
2014-08-29 19:53 ` Arnd Bergmann
2014-08-30 15:54 ` Jason Cooper
2014-08-30 15:54 ` Jason Cooper
[not found] ` <20140830155459.GI3683-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-09-01 8:45 ` Arnd Bergmann
2014-09-01 8:45 ` Arnd Bergmann
2014-09-01 8:47 ` Thierry Reding
2014-09-01 8:47 ` Thierry Reding
2014-08-29 3:27 ` Varka Bhadram
2014-08-29 3:27 ` Varka Bhadram
[not found] ` <53FFF335.1020402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-29 7:29 ` Thierry Reding
2014-08-29 7:29 ` Thierry Reding
2014-08-28 15:31 ` [PATCH v4 4/5] ARM: tegra: Remove unused GIC initialization Thierry Reding
2014-08-28 15:31 ` Thierry Reding
2014-08-28 15:31 ` [PATCH v4 5/5] ARM: tegra: Remove unused defines Thierry Reding
2014-08-28 15:31 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4707330.BNuO2MquVF@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.