From: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: "containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org"
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH][for -mm] Fix and Enhancements for memory cgroup [2/6] fix err handling in charging
Date: Tue, 09 Oct 2007 16:18:08 +0530 [thread overview]
Message-ID: <470B5C68.2070800@linux.vnet.ibm.com> (raw)
In-Reply-To: <20071009185018.4d279d07.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
KAMEZAWA Hiroyuki wrote:
> This unlock_page_cgroup() is unnecessary.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
>
>
> mm/memcontrol.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-2.6.23-rc8-mm2/mm/memcontrol.c
> ===================================================================
> --- linux-2.6.23-rc8-mm2.orig/mm/memcontrol.c
> +++ linux-2.6.23-rc8-mm2/mm/memcontrol.c
> @@ -381,9 +381,7 @@ done:
> return 0;
> free_pc:
> kfree(pc);
> - return -ENOMEM;
> err:
> - unlock_page_cgroup(page);
> return -ENOMEM;
> }
>
>
Looks good to me
Acked-by: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"containers@lists.osdl.org" <containers@lists.osdl.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH][for -mm] Fix and Enhancements for memory cgroup [2/6] fix err handling in charging
Date: Tue, 09 Oct 2007 16:18:08 +0530 [thread overview]
Message-ID: <470B5C68.2070800@linux.vnet.ibm.com> (raw)
In-Reply-To: <20071009185018.4d279d07.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> This unlock_page_cgroup() is unnecessary.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
>
> mm/memcontrol.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-2.6.23-rc8-mm2/mm/memcontrol.c
> ===================================================================
> --- linux-2.6.23-rc8-mm2.orig/mm/memcontrol.c
> +++ linux-2.6.23-rc8-mm2/mm/memcontrol.c
> @@ -381,9 +381,7 @@ done:
> return 0;
> free_pc:
> kfree(pc);
> - return -ENOMEM;
> err:
> - unlock_page_cgroup(page);
> return -ENOMEM;
> }
>
>
Looks good to me
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-09 10:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 9:46 [PATCH][for -mm] Fix and Enhancements for memory cgroup [0/6] intro KAMEZAWA Hiroyuki
2007-10-09 9:46 ` KAMEZAWA Hiroyuki
[not found] ` <20071009184620.8b14cbc6.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 9:49 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [1/6] fix refcnt race in charge/uncharge KAMEZAWA Hiroyuki
2007-10-09 9:49 ` KAMEZAWA Hiroyuki
[not found] ` <20071009184925.ad8248d4.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 10:38 ` Balbir Singh
2007-10-09 10:38 ` Balbir Singh
2007-10-09 22:31 ` YAMAMOTO Takashi
2007-10-09 22:31 ` YAMAMOTO Takashi
[not found] ` <20071009223139.061C21BF47A-Pcsii4f/SVk@public.gmane.org>
2007-10-10 0:34 ` KAMEZAWA Hiroyuki
2007-10-10 0:34 ` KAMEZAWA Hiroyuki
2007-10-09 9:50 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [2/6] fix err handling in charging KAMEZAWA Hiroyuki
2007-10-09 9:50 ` KAMEZAWA Hiroyuki
[not found] ` <20071009185018.4d279d07.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 10:48 ` Balbir Singh [this message]
2007-10-09 10:48 ` Balbir Singh
2007-10-09 9:51 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [3/6] add helper function for page_cgroup KAMEZAWA Hiroyuki
2007-10-09 9:51 ` KAMEZAWA Hiroyuki
[not found] ` <20071009185132.a870b0f0.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 11:09 ` Balbir Singh
2007-10-09 11:09 ` Balbir Singh
[not found] ` <470B617C.1060504-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2007-10-09 11:26 ` KAMEZAWA Hiroyuki
2007-10-09 11:26 ` KAMEZAWA Hiroyuki
[not found] ` <20071009202642.9f174445.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-10 0:38 ` KAMEZAWA Hiroyuki
2007-10-10 0:38 ` KAMEZAWA Hiroyuki
2007-10-09 9:53 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [4/6] avoid handling !LRU page in mem_cgroup_isolate_pages KAMEZAWA Hiroyuki
2007-10-09 9:53 ` KAMEZAWA Hiroyuki
[not found] ` <20071009185341.d395bece.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 15:35 ` Balbir Singh
2007-10-09 15:35 ` Balbir Singh
2007-10-09 9:54 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [5/6] memory cgroup and migration fix KAMEZAWA Hiroyuki
2007-10-09 9:54 ` KAMEZAWA Hiroyuki
[not found] ` <20071009185459.49663a71.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 16:26 ` Balbir Singh
2007-10-09 16:26 ` Balbir Singh
2007-10-09 9:55 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [6/6] add force reclaim interface KAMEZAWA Hiroyuki
2007-10-09 9:55 ` KAMEZAWA Hiroyuki
[not found] ` <20071009185556.c6117b31.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-09 18:44 ` Balbir Singh
2007-10-09 18:44 ` Balbir Singh
[not found] ` <470BCC25.7040302-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2007-10-10 0:41 ` KAMEZAWA Hiroyuki
2007-10-10 0:41 ` KAMEZAWA Hiroyuki
2007-10-09 10:30 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [0/6] intro Balbir Singh
2007-10-09 10:30 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470B5C68.2070800@linux.vnet.ibm.com \
--to=balbir-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.