From: Josh Triplett <josh@freedesktop.org>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
Pierre Ossman <drzeus@drzeus.cx>,
akpm@osdl.org, linux-sparse@vger.kernel.org
Subject: Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree)
Date: Wed, 10 Oct 2007 04:45:46 -0700 [thread overview]
Message-ID: <470CBB6A.7020305@freedesktop.org> (raw)
In-Reply-To: <20071010104540.GA6366@localhost.sw.ru>
Alexey Dobriyan wrote:
> ["if (!x & y)" patch from yanzheng@]
> ["if (!x & y)" patch from adobriyan@]
> ["if (!x & y)" patches from viro@]
>
> While we're at it, below is somewhat ugly sparse patch for detecting
> "&& 0x" typos.
Excellent idea! I think it applies to || as well. I'll most likely
add a -Wboolean-logic-on-bit-constant to turn this warning on.
Any reason why this wouldn't apply to octal constants or to GCC's new
binary constants? I can trivially modify this patch to handle those
as well, just by dropping the check for an 'x' or 'X', and renaming the
flag.
As far as patch beauty goes, I think this patch looks just fine.
- Josh Triplett
next prev parent reply other threads:[~2007-10-10 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 10:45 idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree) Alexey Dobriyan
2007-10-10 11:23 ` Andreas Schwab
2007-10-10 11:45 ` Josh Triplett [this message]
2007-10-11 7:35 ` Alexey Dobriyan
2007-10-11 9:00 ` Kyle Moffett
2007-10-11 16:27 ` Josh Triplett
2007-10-10 13:35 ` Morten Welinder
2007-10-10 18:08 ` Josh Triplett
2007-10-10 19:02 ` Pavel Roskin
2007-10-10 18:22 ` Pierre Ossman
2007-10-11 13:57 ` Alex Dubov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470CBB6A.7020305@freedesktop.org \
--to=josh@freedesktop.org \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.