building audit-1.6.x is broken in RHEL5[.x]

building audit-1.6.x is broken in RHEL5[.x]

[Klaus Heinrich Kiwi]

Miloslav,

  I'm unable to build audit 1.6.x in RHEL5 or RHEL5 update1 (as of
snap8) using rpmbuild. I'm directing you this report as looks like the
problem lies in the system-config-audit package.

Seems like something is failing to replace @DATADIRNAME@ for 'share'
while intltoolize'ing, even though there's a m4 macro within
m4/gettext.m4 that says:
    dnl For backward compatibility. Some Makefiles may be using this.
    DATADIRNAME=share
    AC_SUBST(DATADIRNAME)

However, rpmbuild --rebuild audit-1.6.1-1.src.rpm fails with:
----------
...
Making install in po
make[1]: Entering directory `/usr/src/redhat/BUILD/audit-1.6.1/system-config-audit/po'
/usr/src/redhat/BUILD/audit-1.6.1/system-config-audit/admin/install-sh -d /var/tmp/audit-1.6.1-root/usr/@DATADIRNAME@/locale
if test -n "cs"; then \
...
installing cs.gmo as /var/tmp/audit-1.6.1-root/usr/@DATADIRNAME@/locale/cs/LC_MESSAGES/system-config-audit.mo
...
+ /usr/lib/rpm/redhat/find-lang.sh /var/tmp/audit-1.6.1-root system-config-audit
No translations found for system-config-audit in /var/tmp/audit-1.6.1-root
error: Bad exit status from /var/tmp/rpm-tmp.55808 (%install)
----------
The translation is installed as '.../@DATADIRNAME@/locale/...' and
find-lang.sh tries to find '*/share/locale/*' translations.

Building in Fedora7 works (probably because of updated intltool package
- see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=373643)

I don't understand why the AC_SUBST(DATADIRNAME) macro isn't working and
I'd like to build the package in an unmodified RHEL5 (GA) server. Anyone
have a clue on how to fix this? Isn't it worth fixing it upstream?

btw, why is there a 'Makefile.in.in~' file inside
system-config-audit/po?

Thanks,

 Klaus H. Kiwi

Re: building audit-1.6.x is broken in RHEL5[.x]

[klausk]

[-- Attachment #1.1: Type: text/plain, Size: 968 bytes --]

> find-lang.sh tries to find '*/share/locale/*' translations.
> 
> Building in Fedora7 works (probably because of updated intltool package
> - see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=373643)
> 

I updated to intltool-0.35.5-3 and got past the @DATADIRNAME@ error, but 
something is still failing:

Processing files: system-config-audit-0.4.3-1
error: File not found: 
/var/tmp/audit-1.6.2-root/usr/share/applications/system-config-audit.desktop

This time, seems like system-config-audit.desktop got install'ed to a 
wrong location:
test -z "/applications" || mkdir -p -- 
"/var/tmp/audit-1.6.2-root/applications"
 /usr/bin/install -c -m 644 'system-config-audit.desktop' 
'/var/tmp/audit-1.6.2-root/applications/system-config-audit.desktop'

So more places are missing @DATADIRNAME@

Any thoughts?

 Klaus


-- 
Klaus Heinrich Kiwi/Brazil/IBM <klausk@br.ibm.com>
Software Engineer
IBM STG, Linux Technology Center
Phone:(+55-19) 2132-1909 [T/L 839-1909]

[-- Attachment #1.2: Type: text/html, Size: 1583 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: building audit-1.6.x is broken in RHEL5[.x]

[Steve Grubb]

On Tuesday 09 October 2007 11:47:19 klausk@br.ibm.com wrote:
> This time, seems like system-config-audit.desktop got install'ed to a
> wrong location:

Right, the gnome desktop changed between RHEL5 GA and current Fedora. 
This is the patch I have in RHEL5 for this difference:


diff -urp audit-1.5.5/system-config-audit/system-config-audit.desktop.in audit-1.5.6/system-config-audit/system-config-audit.desktop.in
--- audit-1.5.5/system-config-audit/system-config-audit.desktop.in      2007-05-14 18:41:31.000000000 -0400
+++ audit-1.5.6/system-config-audit/system-config-audit.desktop.in      2007-07-23 17:38:48.000000000 -0400
@@ -6,4 +6,4 @@ Exec=system-config-audit
 Terminal=false
 Type=Application
 Icon=logviewer
-Categories=Settings;
\ No newline at end of file
+Categories=Settings;System;X-Red-Hat-Base;Application;SystemSetup;

Re: building audit-1.6.x is broken in RHEL5[.x]

[klausk]

[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]

Steve Grubb <sgrubb@redhat.com> wrote on 10/09/2007 01:01:45 PM:

> On Tuesday 09 October 2007 11:47:19 klausk@br.ibm.com wrote:
> > This time, seems like system-config-audit.desktop got install'ed to a
> > wrong location:
> 
> Right, the gnome desktop changed between RHEL5 GA and current Fedora. 
> This is the patch I have in RHEL5 for this difference:
...
> +Categories=Settings;System;X-Red-Hat-Base;Application;SystemSetup;

Still no luck:

error: File not found: 
/var/tmp/audit-1.6.2-root/usr/share/applications/system-config-audit.desktop

In the generated Makefile, I see:
applicationsdir = $(datarootdir)/applications
but no other references to datarootdir

-- 
Klaus Heinrich Kiwi/Brazil/IBM <klausk@br.ibm.com>
Software Engineer
IBM STG, Linux Technology Center
Phone:(+55-19) 2132-1909 [T/L 839-1909]

[-- Attachment #1.2: Type: text/html, Size: 1161 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: building audit-1.6.x is broken in RHEL5[.x]

[Miloslav Trmac]

[-- Attachment #1: Type: text/plain, Size: 2411 bytes --]

Hello,
Klaus Heinrich Kiwi napsal(a):
>   I'm unable to build audit 1.6.x in RHEL5 or RHEL5 update1 (as of
> snap8) using rpmbuild. I'm directing you this report as looks like the
> problem lies in the system-config-audit package.
The correct solution is to:
* create the audit tarball using (make dist)
* remove the autotools invocations from the spec file.

This should make the build process independent of versions - or even
presence - of autotools on the build machine.  OTOH patching the build
machinery in the spec file might become more difficult.


Now, for the problems encountered while using the current tarballs:
> Seems like something is failing to replace @DATADIRNAME@ for 'share'
> while intltoolize'ing, even though there's a m4 macro within
> m4/gettext.m4 that says:
>     dnl For backward compatibility. Some Makefiles may be using this.
>     DATADIRNAME=share
>     AC_SUBST(DATADIRNAME)
> 
> I don't understand why the AC_SUBST(DATADIRNAME) macro isn't working and
> I'd like to build the package in an unmodified RHEL5 (GA) server.
The AC_SUBST(DATADIRNAME) is performed only in a branch that isn't
executed in system-config-audit (because AM_GNU_GETTEXT has the
"external" parameter).  intltool relies on gettext providing the
substitution, and gettext stopped doing so.

> Anyone
> have a clue on how to fix this? Isn't it worth fixing it upstream?
The correct fix is to modify intltool not to rely on the substitution;
this is already fixed in later intltool versions.


> This time, seems like system-config-audit.desktop got install'ed to a wrong location:
> test -z "/applications" || mkdir -p -- "/var/tmp/audit-1.6.2-root/applications"
>  /usr/bin/install -c -m 644 'system-config-audit.desktop' '/var/tmp/audit-1.6.2-root/applications/system-config-audit.desktop'
> 
> In the generated Makefile, I see:
> applicationsdir = $(datarootdir)/applications
> but no other references to datarootdir
datarootdir is only provided by autoconf >= 2.59c; the autoconf in RHEL5
is too old.  This problem happens only because configure is regenerated
during the build process.


As a workaround, the attached spec file change works for me when
building rawhide audit-1.6.2-3 on RHEL5.


> btw, why is there a 'Makefile.in.in~' file inside
> system-config-audit/po?
Because the audit distribution tarball is apparently created manually,
and the file was accidentally packaged as well.
	Mirek

[-- Attachment #2: audit.hack.patch --]
[-- Type: text/x-patch, Size: 642 bytes --]

--- audit.spec.hack	2007-10-11 03:41:04.000000000 +0200
+++ audit.spec	2007-10-11 04:02:01.000000000 +0200
@@ -83,8 +83,8 @@
 mkdir -p $RPM_BUILD_ROOT/%{_lib}
 mkdir -p $RPM_BUILD_ROOT/%{_libdir}/audit
 mkdir -p $RPM_BUILD_ROOT/%{_var}/log/audit
-make DESTDIR=$RPM_BUILD_ROOT install
-make -C system-config-audit DESTDIR=$RPM_BUILD_ROOT install-fedora
+make DESTDIR=$RPM_BUILD_ROOT datarootdir=%{_datadir} DATADIRNAME=share install
+make -C system-config-audit DESTDIR=$RPM_BUILD_ROOT datarootdir=%{_datadir} DATADIRNAME=share install-fedora
 
 mkdir -p $RPM_BUILD_ROOT/%{_libdir}
 # This winds up in the wrong place when libtool is involved

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]