All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Borkhuis <j.borkhuis@domain.hid>
To: Xenomai-help@domain.hid
Subject: Re: [Xenomai-help] Passing data from device init to open function
Date: Thu, 11 Oct 2007 09:25:06 +0200	[thread overview]
Message-ID: <470DCFD2.1000908@domain.hid> (raw)
In-Reply-To: <470CB974.6040605@domain.hid>

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

This is something I try to avoid (replying to my own messages), but I'll 
do it this time.

Johan Borkhuis wrote:
> Hello,
>
> I am facing the following problem. During device initialization I am 
> filling a structure with device specific data. This structure is 
> provided to the Linux driver using pci_set_drvdata. Now I want my 
> Xenomai driver to have access to this data as well.
>   

I made a fix for the problem I described, but I would also like to 
propose a change to the rtdm_device structure.

What I did to solve this problem is add the following statement to my 
device initialization function (the PCI probe function) after the 
pci_set_drvdata:

    MyDevice *unit;
    ....
    pci_set_drvdata(dev, unit);
    my_rtdm_device.device_id = (int)dev;

In my ops-functions I can now use the following statement to access the 
device data:

int myrtdm_open_nrt(struct rtdm_dev_context    *context,
                 rtdm_user_info_t              *user_info,
                 int                            oflags)
{
    MyDevice *unit = pci_get_drvdata((struct pci_dev 
*)context->device->device_id);

This does work, but only as long as sizeof(int) == sizeof(<pointer>), 
which is true on 32 bit systems, but not on 64 bit systems. So I would 
like to add an extra pointer field to the rtdm_device structure, 
pointing to some device-data to allow this to work on both 32 and 64 bit 
systems.

I attached a diff-file containing a patch to rtdm_driver.h that makes 
this change.

Kind regards,
    Johan Borkhuis


[-- Attachment #2: xeno.diff --]
[-- Type: text/plain, Size: 597 bytes --]

diff -u -r org/xenomai-2.3.2/include/rtdm/rtdm_driver.h xenomai-2.3.2/include/rtdm/rtdm_driver.h
--- org/xenomai-2.3.2/include/rtdm/rtdm_driver.h	2007-02-19 15:09:49.000000000 +0100
+++ xenomai-2.3.2/include/rtdm/rtdm_driver.h	2007-10-11 09:15:36.000000000 +0200
@@ -428,6 +428,9 @@
     /** Driver definable device ID */
     int                             device_id;
 
+    /** Driver definable device data */
+    void                            *device_data;
+
     /** Data stored by RTDM inside a registered device (internal use only) */
     struct rtdm_dev_reserved        reserved;
 };


  reply	other threads:[~2007-10-11  7:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10 11:37 [Xenomai-help] Passing data from device init to open function Johan Borkhuis
2007-10-11  7:25 ` Johan Borkhuis [this message]
2007-10-11 13:51   ` Jan Kiszka
2007-10-12  7:38     ` Johan Borkhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470DCFD2.1000908@domain.hid \
    --to=j.borkhuis@domain.hid \
    --cc=Xenomai-help@domain.hid \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.