From: Johan Borkhuis <j.borkhuis@domain.hid>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: Xenomai-help@domain.hid
Subject: Re: [Xenomai-help] Passing data from device init to open function
Date: Fri, 12 Oct 2007 09:38:36 +0200 [thread overview]
Message-ID: <470F247C.1060502@domain.hid> (raw)
In-Reply-To: <470E2A6F.2020406@domain.hid>
Jan Kiszka wrote:
>> This does work, but only as long as sizeof(int) == sizeof(<pointer>),
>> which is true on 32 bit systems, but not on 64 bit systems. So I would
>> like to add an extra pointer field to the rtdm_device structure,
>> pointing to some device-data to allow this to work on both 32 and 64 bit
>> systems.
>>
> Hmm, that's what we had in an early RTDM version, but the more common
> use-case turned out to be
>
> per_device_data = my_per_device_data[device->device_id];
>
> where my_per_device_data is a global variable, typical a data structure
> containing all the required per-device information.
>
I considered that as well. The main problem is that you have to
statically allocate the memory based on the maximum number of devices
you want to support, and I prefer to allocate the memory for each
available device.
> Anyway, as you are adding this field, not replacing the ID with it, I
> think I'm going to merge this.
>
One should have a very good reason to replace or remove a field in a
system-structure, and this is just an addition to the structure, so no
real need to replace anything.
Thanks.
Kind regards,
Johan Borkhuis
prev parent reply other threads:[~2007-10-12 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 11:37 [Xenomai-help] Passing data from device init to open function Johan Borkhuis
2007-10-11 7:25 ` Johan Borkhuis
2007-10-11 13:51 ` Jan Kiszka
2007-10-12 7:38 ` Johan Borkhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470F247C.1060502@domain.hid \
--to=j.borkhuis@domain.hid \
--cc=Xenomai-help@domain.hid \
--cc=jan.kiszka@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.