* [PATCH][NETNS] Don't panic on creating the namespace's loopback
@ 2007-10-15 10:23 Pavel Emelyanov
2007-10-15 19:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-10-15 10:23 UTC (permalink / raw)
To: David Miller; +Cc: Eric W. Biederman, Daniel Lezcano, Linux Netdev List, devel
When the loopback device is failed to initialize inside the new
namespaces, panic() is called. Do not do it when the namespace
in question is not the init_net.
Plus cleanup the error path a bit.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
drivers/net/loopback.c | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index be25aa3..662b8d1 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -265,17 +265,16 @@ static __net_init int loopback_net_init(struct net *net)
if (err)
goto out_free_netdev;
- err = 0;
net->loopback_dev = dev;
+ return 0;
-out:
- if (err)
- panic("loopback: Failed to register netdevice: %d\n", err);
- return err;
out_free_netdev:
free_netdev(dev);
- goto out;
+out:
+ if (net == &init_net)
+ panic("loopback: Failed to register netdevice: %d\n", err);
+ return err;
}
static __net_exit void loopback_net_exit(struct net *net)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][NETNS] Don't panic on creating the namespace's loopback
2007-10-15 10:23 [PATCH][NETNS] Don't panic on creating the namespace's loopback Pavel Emelyanov
@ 2007-10-15 19:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-10-15 19:55 UTC (permalink / raw)
To: xemul; +Cc: ebiederm, dlezcano, netdev, devel
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 15 Oct 2007 14:23:13 +0400
> When the loopback device is failed to initialize inside the new
> namespaces, panic() is called. Do not do it when the namespace
> in question is not the init_net.
>
> Plus cleanup the error path a bit.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Fair enough, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-15 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 10:23 [PATCH][NETNS] Don't panic on creating the namespace's loopback Pavel Emelyanov
2007-10-15 19:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.