* [patch 3/4] WOL bugfix for 3c59x.c
@ 2007-10-16 21:24 akpm
2007-10-17 1:16 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-10-16 21:24 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, klassert, hcoin
From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Some NICs (3c905B) can not generate PME in power state PCI_D0, while others
like 3c905C can. Call pci_enable_wake() with PCI_D3hot should give proper
WOL for 3c905B.
Signed-off-by: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Tested-by: Harry Coin <hcoin@n4comm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/3c59x.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff -puN drivers/net/3c59x.c~wol-bugfix-for-3c59xc drivers/net/3c59x.c
--- a/drivers/net/3c59x.c~wol-bugfix-for-3c59xc
+++ a/drivers/net/3c59x.c
@@ -3118,7 +3118,13 @@ static void acpi_set_WOL(struct net_devi
iowrite16(SetRxFilter|RxStation|RxMulticast|RxBroadcast, ioaddr + EL3_CMD);
iowrite16(RxEnable, ioaddr + EL3_CMD);
- pci_enable_wake(VORTEX_PCI(vp), 0, 1);
+ if (pci_enable_wake(VORTEX_PCI(vp), PCI_D3hot, 1)) {
+ printk(KERN_INFO "%s: WOL not supported.\n",
+ pci_name(VORTEX_PCI(vp)));
+
+ vp->enable_wol = 0;
+ return;
+ }
/* Change the power state to D3; RxEnable doesn't take effect. */
pci_set_power_state(VORTEX_PCI(vp), PCI_D3hot);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 3/4] WOL bugfix for 3c59x.c
2007-10-16 21:24 [patch 3/4] WOL bugfix for 3c59x.c akpm
@ 2007-10-17 1:16 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-10-17 1:16 UTC (permalink / raw)
To: akpm; +Cc: netdev, klassert, hcoin
akpm@linux-foundation.org wrote:
> From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
>
> Some NICs (3c905B) can not generate PME in power state PCI_D0, while others
> like 3c905C can. Call pci_enable_wake() with PCI_D3hot should give proper
> WOL for 3c905B.
>
> Signed-off-by: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
> Tested-by: Harry Coin <hcoin@n4comm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/3c59x.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-17 1:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-16 21:24 [patch 3/4] WOL bugfix for 3c59x.c akpm
2007-10-17 1:16 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.