Re: [PATCH v2 1/4] Implement {read,update}_persistent_clock.

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Benjamin Herrenschmidt wrote:

>>   Eh... poor you. Tony got clockevent driver reengineered for no apparent 
>>reason.  And he's introduced the jiffy drift by deleting the main loop from 
>>timer_interrupt(). Yet this borken version was preferred to what was known 
>>working since about 2.6.18 and included into 2.6.21-rt patchset.  I don't like 
>>that policy. Will you be pushing fixes from -rt to PowerPC, or will it fall on 
>>my shoulders now?

> Possibly because whatever implementation existed before was never
> provided in a mergeable form

    The fact that vDSO calls were removed out of the necessity (because having 
the broken TOD stuff removed was better than to leave it in place producing 
inexact results) doesn't mean that everything in the patches provided was 
broken and of no use.  Yet you want everything removed in favor of somewhat 
dubious implementation.

> and pushed to -rt bypassing the powerpc architecture maintainer ?

    There was no bypassing, everything was submitted publicly via this list. 
The -rt patch (via the hrtimers patchset) was the place to merge the hrtimers 
code at thiat time, and nobody showed any interest in making the code better, 
i.e. amending vDSO stuff, for months... (The question also is why Tony was 
submitting his patches also to linux-rt-users while they were known not to 
apply to the -rt patch.)

> Ben.

WBR, Sergei