From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] split i386-generic part of i386/pc/loader.h
Date: Thu, 18 Oct 2007 17:58:17 +0300 [thread overview]
Message-ID: <47177489.3060607@nic.fi> (raw)
In-Reply-To: <20071017194526.GA23951@thorin>
Robert Millan wrote:
> On Wed, Oct 17, 2007 at 09:17:54PM +0300, Vesa Jääskeläinen wrote:
>> Robert Millan wrote:
>>> This patch splits the i386-generic part of i386/pc/loader.h into i386/loader.h.
>>>
>>> Comments?
>> Why did you move stuff from i386/pc to i386 ?
>>
>> I do see a point on running grub2 on non-pc i386...
>
> It's for LinuxBIOS.
>
If this is some new arch that will be supported on i386 then I would
suggest i386/linuxbios/.
I think the question to be asked here is that does all i386
architectures need this functionality that you extracted. I have nothing
against modularizing code, in example if you compare contents of the efi
and pc directories you will notice that efi does not need most of the
stuff that is present on pc.
Actually I think better name for pc would be pcbios...
If you want to share code with LinuxBIOS why not just share those files
located on i386/pc/.
next prev parent reply other threads:[~2007-10-18 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 8:44 [PATCH] split i386-generic part of i386/pc/loader.h Robert Millan
2007-10-17 8:55 ` Marco Gerards
2007-10-17 9:39 ` Robert Millan
2007-10-17 18:17 ` Vesa Jääskeläinen
2007-10-17 19:45 ` Robert Millan
2007-10-18 14:58 ` Vesa Jääskeläinen [this message]
2007-10-19 20:26 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47177489.3060607@nic.fi \
--to=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.