From: Laurent Vivier <Laurent.Vivier@bull.net>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Avi Kivity <avi@qumranet.com>,
kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Fix guest time accounting going faster than user time accounting
Date: Thu, 18 Oct 2007 21:13:54 +0200 [thread overview]
Message-ID: <4717B072.6090506@bull.net> (raw)
In-Reply-To: <200710181941.31181.borntraeger@de.ibm.com>
Acked-by: Laurent Vivier <Laurent.Vivier@bull.net>
Christian Borntraeger a écrit :
> Seems I overlooked this type while reviewing Laurents patch.
> cputime_add already adds, dont do it twice.
>
> Avi. This should go to Linus before 2.6.24.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> ---
> fs/proc/array.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23/fs/proc/array.c
> ===================================================================
> --- linux-2.6.23.orig/fs/proc/array.c
> +++ linux-2.6.23/fs/proc/array.c
> @@ -446,7 +446,7 @@ static int do_task_stat(struct task_stru
> maj_flt += sig->maj_flt;
> utime = cputime_add(utime, sig->utime);
> stime = cputime_add(stime, sig->stime);
> - gtime += cputime_add(gtime, sig->gtime);
> + gtime = cputime_add(gtime, sig->gtime);
> }
>
> sid = signal_session(sig);
>
--
---------------- Laurent.Vivier@bull.net -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
To: Christian Borntraeger
<borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: Fix guest time accounting going faster than user time accounting
Date: Thu, 18 Oct 2007 21:13:54 +0200 [thread overview]
Message-ID: <4717B072.6090506@bull.net> (raw)
In-Reply-To: <200710181941.31181.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Acked-by: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Christian Borntraeger a écrit :
> Seems I overlooked this type while reviewing Laurents patch.
> cputime_add already adds, dont do it twice.
>
> Avi. This should go to Linus before 2.6.24.
>
> Signed-off-by: Christian Borntraeger <borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
>
> ---
> fs/proc/array.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23/fs/proc/array.c
> ===================================================================
> --- linux-2.6.23.orig/fs/proc/array.c
> +++ linux-2.6.23/fs/proc/array.c
> @@ -446,7 +446,7 @@ static int do_task_stat(struct task_stru
> maj_flt += sig->maj_flt;
> utime = cputime_add(utime, sig->utime);
> stime = cputime_add(stime, sig->stime);
> - gtime += cputime_add(gtime, sig->gtime);
> + gtime = cputime_add(gtime, sig->gtime);
> }
>
> sid = signal_session(sig);
>
--
---------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-18 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 17:41 Fix guest time accounting going faster than user time accounting Christian Borntraeger
2007-10-18 17:41 ` Christian Borntraeger
2007-10-18 19:13 ` Laurent Vivier [this message]
2007-10-18 19:13 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4717B072.6090506@bull.net \
--to=laurent.vivier@bull.net \
--cc=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.