* [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' [not found] <20071019035702.B5C7E108010@picon.linux-foundation.org> @ 2007-10-19 4:53 ` Randy Dunlap 2007-10-19 5:02 ` David Miller 2007-10-20 3:04 ` Jeff Garzik 0 siblings, 2 replies; 4+ messages in thread From: Randy Dunlap @ 2007-10-19 4:53 UTC (permalink / raw) To: bugme-daemon, NetDev [bugme-daemon@bugzilla.kernel.org wrote:] From: Randy Dunlap <randy.dunlap@oracle.com> Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems. ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined! ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined! Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/net/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23-git13.orig/drivers/net/Kconfig +++ linux-2.6.23-git13/drivers/net/Kconfig @@ -2494,7 +2494,7 @@ config CHELSIO_T3 config EHEA tristate "eHEA Ethernet support" - depends on IBMEBUS + depends on IBMEBUS && INET select INET_LRO ---help--- This driver supports the IBM pSeries eHEA ethernet adapter. @@ -2591,7 +2591,7 @@ config S2IO_NAPI config MYRI10GE tristate "Myricom Myri-10G Ethernet support" - depends on PCI + depends on PCI && INET select FW_LOADER select CRC32 select INET_LRO ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' 2007-10-19 4:53 ` [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' Randy Dunlap @ 2007-10-19 5:02 ` David Miller 2007-10-19 5:57 ` Randy Dunlap 2007-10-20 3:04 ` Jeff Garzik 1 sibling, 1 reply; 4+ messages in thread From: David Miller @ 2007-10-19 5:02 UTC (permalink / raw) To: randy.dunlap; +Cc: bugme-daemon, netdev, jeff From: Randy Dunlap <randy.dunlap@oracle.com> Date: Thu, 18 Oct 2007 21:53:50 -0700 > [bugme-daemon@bugzilla.kernel.org wrote:] > > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > Drivers that use lro functions should depend on INET, otherwise they > may not link correctly. Let's not select INET. Select should be used > only for library-like code, not to enable subsystems. > > ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined! > ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Acked-by: David S. Miller <davem@davemloft.net> Jeff, please pick this one up too, thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' 2007-10-19 5:02 ` David Miller @ 2007-10-19 5:57 ` Randy Dunlap 0 siblings, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2007-10-19 5:57 UTC (permalink / raw) To: David Miller; +Cc: netdev, jeff On Thu, 18 Oct 2007 22:02:22 -0700 (PDT) David Miller wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > Date: Thu, 18 Oct 2007 21:53:50 -0700 > > > [bugme-daemon@bugzilla.kernel.org wrote:] > > > > > > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > Drivers that use lro functions should depend on INET, otherwise they > > may not link correctly. Let's not select INET. Select should be used > > only for library-like code, not to enable subsystems. > > > > ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined! > > ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined! > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Acked-by: David S. Miller <davem@davemloft.net> > > Jeff, please pick this one up too, thanks! This patch is for kernel bugzilla #9186, not #9187. Clerical error, sorry about that. --- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' 2007-10-19 4:53 ` [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' Randy Dunlap 2007-10-19 5:02 ` David Miller @ 2007-10-20 3:04 ` Jeff Garzik 1 sibling, 0 replies; 4+ messages in thread From: Jeff Garzik @ 2007-10-20 3:04 UTC (permalink / raw) To: Randy Dunlap; +Cc: bugme-daemon, NetDev Randy Dunlap wrote: > [bugme-daemon@bugzilla.kernel.org wrote:] > > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > Drivers that use lro functions should depend on INET, otherwise they > may not link correctly. Let's not select INET. Select should be used > only for library-like code, not to enable subsystems. > > ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined! > ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> applied ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-20 3:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20071019035702.B5C7E108010@picon.linux-foundation.org>
2007-10-19 4:53 ` [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event' Randy Dunlap
2007-10-19 5:02 ` David Miller
2007-10-19 5:57 ` Randy Dunlap
2007-10-20 3:04 ` Jeff Garzik
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.