From: Jeff Garzik <jgarzik@pobox.com>
To: Olof Johansson <olof@lixom.net>
Cc: joe@perches.com, netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix build break in tsi108.c
Date: Fri, 19 Oct 2007 23:04:12 -0400 [thread overview]
Message-ID: <4719702C.7010004@pobox.com> (raw)
In-Reply-To: <20071020020420.GA20073@lixom.net>
Olof Johansson wrote:
> Fix build break:
>
> drivers/net/tsi108_eth.c: In function 'tsi108_init_one':
> drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev'
> drivers/net/tsi108_eth.c:1633: warning: too few arguments for format
> make[2]: *** [drivers/net/tsi108_eth.o] Error 1
>
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> diff --git a/drivers/net/tsi108_eth.c b/drivers/net/tsi108_eth.c
> index df10af7..35d15e8 100644
> --- a/drivers/net/tsi108_eth.c
> +++ b/drivers/net/tsi108_eth.c
> @@ -1629,7 +1629,7 @@ tsi108_init_one(struct platform_device *pdev)
> goto register_fail;
> }
>
> - printk(KERN_INFO "%s: Tsi108 Gigabit Ethernet, MAC: %s\n"
> + printk(KERN_INFO "%s: Tsi108 Gigabit Ethernet, MAC: %s\n",
> dev->name, print_mac(mac, dev->dev_addr));
> #ifdef DEBUG
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Olof Johansson <olof@lixom.net>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, joe@perches.com
Subject: Re: [PATCH] Fix build break in tsi108.c
Date: Fri, 19 Oct 2007 23:04:12 -0400 [thread overview]
Message-ID: <4719702C.7010004@pobox.com> (raw)
In-Reply-To: <20071020020420.GA20073@lixom.net>
Olof Johansson wrote:
> Fix build break:
>
> drivers/net/tsi108_eth.c: In function 'tsi108_init_one':
> drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev'
> drivers/net/tsi108_eth.c:1633: warning: too few arguments for format
> make[2]: *** [drivers/net/tsi108_eth.o] Error 1
>
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> diff --git a/drivers/net/tsi108_eth.c b/drivers/net/tsi108_eth.c
> index df10af7..35d15e8 100644
> --- a/drivers/net/tsi108_eth.c
> +++ b/drivers/net/tsi108_eth.c
> @@ -1629,7 +1629,7 @@ tsi108_init_one(struct platform_device *pdev)
> goto register_fail;
> }
>
> - printk(KERN_INFO "%s: Tsi108 Gigabit Ethernet, MAC: %s\n"
> + printk(KERN_INFO "%s: Tsi108 Gigabit Ethernet, MAC: %s\n",
> dev->name, print_mac(mac, dev->dev_addr));
> #ifdef DEBUG
applied
next prev parent reply other threads:[~2007-10-20 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 2:04 [PATCH] Fix build break in tsi108.c Olof Johansson
2007-10-20 2:04 ` Olof Johansson
2007-10-20 3:04 ` Jeff Garzik [this message]
2007-10-20 3:04 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4719702C.7010004@pobox.com \
--to=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.