* Re: WM9712 monoout [not found] ` <1193050024.7052.132.camel@localhost.localdomain> @ 2007-10-22 14:12 ` Mike Rapoport 2007-10-22 13:17 ` Takashi Iwai 0 siblings, 1 reply; 4+ messages in thread From: Mike Rapoport @ 2007-10-22 14:12 UTC (permalink / raw) To: Liam Girdwood; +Cc: alsa-devel Liam Girdwood wrote: > On Sun, 2007-10-21 at 09:35 +0200, Mike Rapoport wrote: >> Hello, >> >> I'm trying to enable phone on a board with WM9715 codec. >> I have not found a control responsible for mute/unmute the MONOUT. >> My question is whether I should add this control as platform specific control, >> or it would be correct to patch sound/soc/codecs/wm9712.c? > > It should probably go in the codec driver. It looks like an omission. > >> Also, "Mono Playback Volume" control is not inverted, which seems to be a bug. >> > > Could you send a patch ? Sure. A also found that treble and bass need to be inverted. > Many Thanks > > Liam > Signed-off-by: Mike Rapoport <mike@compulab.co.il> sound/soc/codecs/wm9712.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c index 986b5d5..427cb61 100644 --- a/sound/soc/codecs/wm9712.c +++ b/sound/soc/codecs/wm9712.c @@ -102,7 +102,8 @@ SOC_SINGLE("Speaker Playback ZC Switch", AC97_MASTER, 7, 1, 0), SOC_SINGLE("Speaker Playback Invert Switch", AC97_MASTER, 6, 1, 0), SOC_SINGLE("Headphone Playback ZC Switch", AC97_HEADPHONE, 7, 1, 0), SOC_SINGLE("Mono Playback ZC Switch", AC97_MASTER_MONO, 7, 1, 0), -SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 0), +SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 1), +SOC_SINGLE("Mono Playback Switch", AC97_MASTER_MONO, 15, 1, 1), SOC_SINGLE("ALC Target Volume", AC97_CODEC_CLASS_REV, 12, 15, 0), SOC_SINGLE("ALC Hold Time", AC97_CODEC_CLASS_REV, 8, 15, 0), @@ -145,8 +146,8 @@ SOC_ENUM("Bass Control", wm9712_enum[5]), SOC_SINGLE("Bass Cut-off Switch", AC97_MASTER_TONE, 12, 1, 1), SOC_SINGLE("Tone Cut-off Switch", AC97_MASTER_TONE, 4, 1, 1), SOC_SINGLE("Playback Attenuate (-6dB) Switch", AC97_MASTER_TONE, 6, 1, 0), -SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 0), -SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 0), +SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 1), +SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 1), SOC_SINGLE("Capture ADC Switch", AC97_REC_GAIN, 15, 1, 1), SOC_ENUM("Capture Volume Steps", wm9712_enum[6]), ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: WM9712 monoout 2007-10-22 14:12 ` WM9712 monoout Mike Rapoport @ 2007-10-22 13:17 ` Takashi Iwai 2007-10-22 15:16 ` [PATCH] WM9712 SoC driver fixes (was WM9712 monoout) Mike Rapoport 0 siblings, 1 reply; 4+ messages in thread From: Takashi Iwai @ 2007-10-22 13:17 UTC (permalink / raw) To: Mike Rapoport; +Cc: Liam Girdwood, alsa-devel At Mon, 22 Oct 2007 16:12:14 +0200, Mike Rapoport wrote: > > > Liam Girdwood wrote: > > On Sun, 2007-10-21 at 09:35 +0200, Mike Rapoport wrote: > >> Hello, > >> > >> I'm trying to enable phone on a board with WM9715 codec. > >> I have not found a control responsible for mute/unmute the MONOUT. > >> My question is whether I should add this control as platform specific control, > >> or it would be correct to patch sound/soc/codecs/wm9712.c? > > > > It should probably go in the codec driver. It looks like an omission. > > > >> Also, "Mono Playback Volume" control is not inverted, which seems to be a bug. > >> > > > > Could you send a patch ? > > Sure. A also found that treble and bass need to be inverted. > > > Many Thanks > > > > Liam > > > > Signed-off-by: Mike Rapoport <mike@compulab.co.il> A short description of your patch would be appreciated so that I can commit it to the upstream tree. thanks, Takashi > > sound/soc/codecs/wm9712.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c > index 986b5d5..427cb61 100644 > --- a/sound/soc/codecs/wm9712.c > +++ b/sound/soc/codecs/wm9712.c > @@ -102,7 +102,8 @@ SOC_SINGLE("Speaker Playback ZC Switch", AC97_MASTER, 7, 1, 0), > SOC_SINGLE("Speaker Playback Invert Switch", AC97_MASTER, 6, 1, 0), > SOC_SINGLE("Headphone Playback ZC Switch", AC97_HEADPHONE, 7, 1, 0), > SOC_SINGLE("Mono Playback ZC Switch", AC97_MASTER_MONO, 7, 1, 0), > -SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 0), > +SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 1), > +SOC_SINGLE("Mono Playback Switch", AC97_MASTER_MONO, 15, 1, 1), > > SOC_SINGLE("ALC Target Volume", AC97_CODEC_CLASS_REV, 12, 15, 0), > SOC_SINGLE("ALC Hold Time", AC97_CODEC_CLASS_REV, 8, 15, 0), > @@ -145,8 +146,8 @@ SOC_ENUM("Bass Control", wm9712_enum[5]), > SOC_SINGLE("Bass Cut-off Switch", AC97_MASTER_TONE, 12, 1, 1), > SOC_SINGLE("Tone Cut-off Switch", AC97_MASTER_TONE, 4, 1, 1), > SOC_SINGLE("Playback Attenuate (-6dB) Switch", AC97_MASTER_TONE, 6, 1, 0), > -SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 0), > -SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 0), > +SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 1), > +SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 1), > > SOC_SINGLE("Capture ADC Switch", AC97_REC_GAIN, 15, 1, 1), > SOC_ENUM("Capture Volume Steps", wm9712_enum[6]), > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] WM9712 SoC driver fixes (was WM9712 monoout) 2007-10-22 13:17 ` Takashi Iwai @ 2007-10-22 15:16 ` Mike Rapoport 2007-10-22 14:25 ` Takashi Iwai 0 siblings, 1 reply; 4+ messages in thread From: Mike Rapoport @ 2007-10-22 15:16 UTC (permalink / raw) To: Takashi Iwai; +Cc: Liam Girdwood, alsa-devel Takashi Iwai wrote: > At Mon, 22 Oct 2007 16:12:14 +0200, > Mike Rapoport wrote: >>> >> Signed-off-by: Mike Rapoport <mike@compulab.co.il> > > A short description of your patch would be appreciated so that I can > commit it to the upstream tree. Sorry, missed that... The following patch adds "Mono Playback Switch" control to WM9712 codec SoC driver. Also, it fixes Treble, Bass and Mono playback volume inversion bits. Signed-off-by: Mike Rapoport <mike@compulab.co.il> sound/soc/codecs/wm9712.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c index 986b5d5..427cb61 100644 --- a/sound/soc/codecs/wm9712.c +++ b/sound/soc/codecs/wm9712.c @@ -102,7 +102,8 @@ SOC_SINGLE("Speaker Playback ZC Switch", AC97_MASTER, 7, 1, 0), SOC_SINGLE("Speaker Playback Invert Switch", AC97_MASTER, 6, 1, 0), SOC_SINGLE("Headphone Playback ZC Switch", AC97_HEADPHONE, 7, 1, 0), SOC_SINGLE("Mono Playback ZC Switch", AC97_MASTER_MONO, 7, 1, 0), -SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 0), +SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 1), +SOC_SINGLE("Mono Playback Switch", AC97_MASTER_MONO, 15, 1, 1), SOC_SINGLE("ALC Target Volume", AC97_CODEC_CLASS_REV, 12, 15, 0), SOC_SINGLE("ALC Hold Time", AC97_CODEC_CLASS_REV, 8, 15, 0), @@ -145,8 +146,8 @@ SOC_ENUM("Bass Control", wm9712_enum[5]), SOC_SINGLE("Bass Cut-off Switch", AC97_MASTER_TONE, 12, 1, 1), SOC_SINGLE("Tone Cut-off Switch", AC97_MASTER_TONE, 4, 1, 1), SOC_SINGLE("Playback Attenuate (-6dB) Switch", AC97_MASTER_TONE, 6, 1, 0), -SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 0), -SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 0), +SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 1), +SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 1), SOC_SINGLE("Capture ADC Switch", AC97_REC_GAIN, 15, 1, 1), SOC_ENUM("Capture Volume Steps", wm9712_enum[6]), ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] WM9712 SoC driver fixes (was WM9712 monoout) 2007-10-22 15:16 ` [PATCH] WM9712 SoC driver fixes (was WM9712 monoout) Mike Rapoport @ 2007-10-22 14:25 ` Takashi Iwai 0 siblings, 0 replies; 4+ messages in thread From: Takashi Iwai @ 2007-10-22 14:25 UTC (permalink / raw) To: Mike Rapoport; +Cc: Liam Girdwood, alsa-devel At Mon, 22 Oct 2007 17:16:08 +0200, Mike Rapoport wrote: > > > > Takashi Iwai wrote: > > At Mon, 22 Oct 2007 16:12:14 +0200, > > Mike Rapoport wrote: > >>> > >> Signed-off-by: Mike Rapoport <mike@compulab.co.il> > > > > A short description of your patch would be appreciated so that I can > > commit it to the upstream tree. > > Sorry, missed that... > > The following patch adds "Mono Playback Switch" control to WM9712 codec SoC driver. > Also, it fixes Treble, Bass and Mono playback volume inversion bits. > > Signed-off-by: Mike Rapoport <mike@compulab.co.il> Thanks, now applied to ALSA HG tree. Takashi ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-22 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <471B012E.6050802@compulab.co.il>
[not found] ` <1193050024.7052.132.camel@localhost.localdomain>
2007-10-22 14:12 ` WM9712 monoout Mike Rapoport
2007-10-22 13:17 ` Takashi Iwai
2007-10-22 15:16 ` [PATCH] WM9712 SoC driver fixes (was WM9712 monoout) Mike Rapoport
2007-10-22 14:25 ` Takashi Iwai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.