From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, paulus@samba.org, linux390@de.ibm.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] taskstats scaled time cleanup
Date: Wed, 24 Oct 2007 15:22:21 +0530 [thread overview]
Message-ID: <471F15D5.3050100@linux.vnet.ibm.com> (raw)
In-Reply-To: <8789.1193208897@neuling.org>
Michael Neuling wrote:
> This moves the ability to scale cputime into generic code. This
> allows us to fix the issue in kernel/timer.c (noticed by Balbir) where
> we could only add an unscaled value to the scaled utime/stime.
>
> This adds a cputime_to_scaled function. As before, the POWERPC
> version does the scaling based on the last SPURR/PURR ratio
> calculated. The generic and s390 (only other arch to implement
> asm/cputime.h) versions are both NOPs.
>
> Also moves the SPURR and PURR snapshots closer.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
Looks good to me
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: paulus@samba.org, akpm@linux-foundation.org, linux390@de.ibm.com,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] taskstats scaled time cleanup
Date: Wed, 24 Oct 2007 15:22:21 +0530 [thread overview]
Message-ID: <471F15D5.3050100@linux.vnet.ibm.com> (raw)
In-Reply-To: <8789.1193208897@neuling.org>
Michael Neuling wrote:
> This moves the ability to scale cputime into generic code. This
> allows us to fix the issue in kernel/timer.c (noticed by Balbir) where
> we could only add an unscaled value to the scaled utime/stime.
>
> This adds a cputime_to_scaled function. As before, the POWERPC
> version does the scaling based on the last SPURR/PURR ratio
> calculated. The generic and s390 (only other arch to implement
> asm/cputime.h) versions are both NOPs.
>
> Also moves the SPURR and PURR snapshots closer.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
Looks good to me
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2007-10-24 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 6:54 [PATCH] taskstats scaled time cleanup Michael Neuling
2007-10-24 6:54 ` Michael Neuling
2007-10-24 9:52 ` Balbir Singh [this message]
2007-10-24 9:52 ` Balbir Singh
2007-10-24 23:33 ` Andrew Morton
2007-10-24 23:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471F15D5.3050100@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.