From: Jeff Garzik <jeff@garzik.org>
To: eranian@hpl.hp.com
Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
joshua.i.stone@intel.com, juan.villacis@intel.com
Subject: Re: [PATCH] IA64/perfmon: kill dead code, clean irq handling
Date: Thu, 25 Oct 2007 08:51:57 +0000 [thread overview]
Message-ID: <4720592D.4030604@garzik.org> (raw)
In-Reply-To: <20071025084615.GA32656@frankl.hpl.hp.com>
Stephane Eranian wrote:
> Jeff,
>
> On Tue, Oct 23, 2007 at 07:09:08PM -0400, Jeff Garzik wrote:
>> By deleting unused code, this makes perfmon irq handling more efficient,
>> as well as reducing code size.
>>
>> * remove unused pfm_install_alt_pmu_interrupt()
>> * remove unused pfm_remove_alt_pmu_interrupt()
>>
> I have not problem with the patch except maybe for those two functions.
> How do you know they are not used?
> Have you checked the VTUNE open-source driver?
> I thought at some point they were using this hook.
I was hoping some IA-64 person could speak authoritatively on the subject :)
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: eranian@hpl.hp.com
Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
joshua.i.stone@intel.com, juan.villacis@intel.com
Subject: Re: [PATCH] IA64/perfmon: kill dead code, clean irq handling
Date: Thu, 25 Oct 2007 04:51:57 -0400 [thread overview]
Message-ID: <4720592D.4030604@garzik.org> (raw)
In-Reply-To: <20071025084615.GA32656@frankl.hpl.hp.com>
Stephane Eranian wrote:
> Jeff,
>
> On Tue, Oct 23, 2007 at 07:09:08PM -0400, Jeff Garzik wrote:
>> By deleting unused code, this makes perfmon irq handling more efficient,
>> as well as reducing code size.
>>
>> * remove unused pfm_install_alt_pmu_interrupt()
>> * remove unused pfm_remove_alt_pmu_interrupt()
>>
> I have not problem with the patch except maybe for those two functions.
> How do you know they are not used?
> Have you checked the VTUNE open-source driver?
> I thought at some point they were using this hook.
I was hoping some IA-64 person could speak authoritatively on the subject :)
Jeff
next prev parent reply other threads:[~2007-10-25 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 23:09 [PATCH] IA64/perfmon: kill dead code, clean irq handling Jeff Garzik
2007-10-23 23:09 ` Jeff Garzik
2007-10-25 8:46 ` Stephane Eranian
2007-10-25 8:46 ` Stephane Eranian
2007-10-25 8:51 ` Jeff Garzik [this message]
2007-10-25 8:51 ` Jeff Garzik
2007-10-25 11:05 ` Villacis, Juan
2007-10-25 11:05 ` Villacis, Juan
2007-10-25 11:17 ` Christoph Hellwig
2007-10-25 11:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4720592D.4030604@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=eranian@hpl.hp.com \
--cc=joshua.i.stone@intel.com \
--cc=juan.villacis@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.