All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, andrew.m.paprocki@gmail.com,
	ballen@gravity.phys.uwm.edu
Subject: Re: [PATCH #upstream] libata: relocate and fix post-command processing
Date: Thu, 25 Oct 2007 05:38:15 -0400	[thread overview]
Message-ID: <47206407.4030908@garzik.org> (raw)
In-Reply-To: <20071025092244.GJ11853@htj.dyndns.org>

Tejun Heo wrote:
> Some commands need post-processing after successful completion.  This
> was done in ata_scsi_qc_complete() till now but this has the following
> problems.
> 
> * Post-command processing gets executed when qc is completed from EH.
>   Some qc's are retried from EH with zero err_mask and thus triggers
>   unnecessary/incorrect post-command processing.
> 
> * Command post processing doesn't belong to SAT layer.
> 
> * Link-wide revalidation was scheduled where device revalidation
>   suffices.
> 
> This patch moves post-command processing to success completion path of
> ata_qc_complete() which is travelled iff the command is going to be
> completed without passing through EH and updates post-command
> processing such that device-specific action is used.  While at it,
> restructure code a bit for readability.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied

now if only I had a way for the SAT to issue CHECK POWER MODE (used in 
TEST UNIT READY translation), and inspect qc->err_mask before EH gets 
its hands on it...  :)



  reply	other threads:[~2007-10-25  9:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25  9:22 [PATCH #upstream] libata: relocate and fix post-command processing Tejun Heo
2007-10-25  9:38 ` Jeff Garzik [this message]
2007-10-25  9:41   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47206407.4030908@garzik.org \
    --to=jeff@garzik.org \
    --cc=andrew.m.paprocki@gmail.com \
    --cc=ballen@gravity.phys.uwm.edu \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.