Re: [PATCH #upstream] libata: relocate and fix post-command processing

[Tejun Heo <htejun@gmail.com>]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Some commands need post-processing after successful completion.  This
>> was done in ata_scsi_qc_complete() till now but this has the following
>> problems.
>>
>> * Post-command processing gets executed when qc is completed from EH.
>>   Some qc's are retried from EH with zero err_mask and thus triggers
>>   unnecessary/incorrect post-command processing.
>>
>> * Command post processing doesn't belong to SAT layer.
>>
>> * Link-wide revalidation was scheduled where device revalidation
>>   suffices.
>>
>> This patch moves post-command processing to success completion path of
>> ata_qc_complete() which is travelled iff the command is going to be
>> completed without passing through EH and updates post-command
>> processing such that device-specific action is used.  While at it,
>> restructure code a bit for readability.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> applied
> 
> now if only I had a way for the SAT to issue CHECK POWER MODE (used in 
> TEST UNIT READY translation), and inspect qc->err_mask before EH gets 
> its hands on it...  :)

Yeah, yeah, SAT error pass-through is coming.  :-)

-- 
tejun