From: "Steven A. Falco" <sfalco@domain.hid>
To: xenomai@xenomai.org
Subject: [Xenomai-core] Proposed arch/powerpc/sysdev/uic.c patch
Date: Thu, 25 Oct 2007 16:10:16 -0400 [thread overview]
Message-ID: <4720F828.1030200@domain.hid> (raw)
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
I applied the uic patch:
diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c
index eeb38e2..5a38086 100644
--- a/arch/powerpc/sysdev/uic.c
+++ b/arch/powerpc/sysdev/uic.c
@@ -48,7 +48,7 @@ struct uic {
int index;
int dcrbase;
- spinlock_t lock;
+ ipipe_spinlock_t lock;
/* The remapper for this UIC */
struct irq_host *irqhost;
However, this would not compile because of a type mismatch. I have added the attached patch, and it now compiles and runs. But I'm not sure if this is the right way to fix it. Comments?
Steve
[-- Attachment #2: new.patch --]
[-- Type: text/x-patch, Size: 416 bytes --]
--- /home/sfalco/uic.c 2007-10-25 15:59:35.000000000 -0400
+++ arch/powerpc/sysdev/uic.c 2007-10-25 16:06:16.000000000 -0400
@@ -231,7 +231,7 @@
return NULL; /* FIXME: panic? */
memset(uic, 0, sizeof(*uic));
- spin_lock_init(&uic->lock);
+ uic->lock = IPIPE_SPIN_LOCK_UNLOCKED;
uic->of_node = of_node_get(node);
indexp = of_get_property(node, "cell-index", &len);
if (!indexp || (len != sizeof(u32))) {
next reply other threads:[~2007-10-25 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 20:10 Steven A. Falco [this message]
2007-10-25 20:22 ` [Xenomai-core] Proposed arch/powerpc/sysdev/uic.c patch Philippe Gerum
2007-10-25 20:37 ` Jan Kiszka
2007-10-25 21:03 ` Philippe Gerum
2007-10-26 8:32 ` Jan Kiszka
2007-10-26 10:06 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4720F828.1030200@domain.hid \
--to=sfalco@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.