From: Philippe Gerum <rpm@xenomai.org>
To: "Steven A. Falco" <sfalco@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-core] Proposed arch/powerpc/sysdev/uic.c patch
Date: Thu, 25 Oct 2007 22:22:31 +0200 [thread overview]
Message-ID: <4720FB07.10606@domain.hid> (raw)
In-Reply-To: <4720F828.1030200@domain.hid>
Steven A. Falco wrote:
> I applied the uic patch:
>
> diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c
> index eeb38e2..5a38086 100644
> --- a/arch/powerpc/sysdev/uic.c
> +++ b/arch/powerpc/sysdev/uic.c
> @@ -48,7 +48,7 @@ struct uic {
> int index;
> int dcrbase;
>
> - spinlock_t lock;
> + ipipe_spinlock_t lock;
>
> /* The remapper for this UIC */
> struct irq_host *irqhost;
>
> However, this would not compile because of a type mismatch. I have
> added the attached patch, and it now compiles and runs. But I'm not
> sure if this is the right way to fix it. Comments?
>
This will work for the purpose of running an I-pipe enabled kernel, but
would fail with CONFIG_IPIPE disabled. Since we need to provide both,
I'm going to work on the proper patch for fixing the issue both ways.
Still, your patch will work as expected for running Xenomai.
> Steve
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
--
Philippe.
next prev parent reply other threads:[~2007-10-25 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 20:10 [Xenomai-core] Proposed arch/powerpc/sysdev/uic.c patch Steven A. Falco
2007-10-25 20:22 ` Philippe Gerum [this message]
2007-10-25 20:37 ` Jan Kiszka
2007-10-25 21:03 ` Philippe Gerum
2007-10-26 8:32 ` Jan Kiszka
2007-10-26 10:06 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4720FB07.10606@domain.hid \
--to=rpm@xenomai.org \
--cc=sfalco@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.