From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: jeff@garzik.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] e1000e: Fix jumbo frame receive code.
Date: Thu, 25 Oct 2007 14:05:41 -0700 [thread overview]
Message-ID: <47210525.4020606@intel.com> (raw)
In-Reply-To: <20071025205744.32645.59503.stgit@localhost.localdomain>
Auke Kok wrote:
> Fix allocation and freeing of jumbo frames where several bugs
> were recently introduced by cleanups after we forked this code
> from e1000. This moves ps_pages to buffer_info where it really
> belongs and makes it a dynamically allocated array. The penalty
> is not that high since it's allocated outside of the buffer_info
> struct anyway.
>
> Without this patch all jumbo frames are completely broken and the
> driver panics.
Jeff,
I strongly suggest that you apply patches #1 and #2 (but preferably all) to
#upstream-fixes since these patches fix the -absolutely- broken jumbo frames code
in e1000e. On top of that patches #1 and #2 only touch the jumbo frame codepath,
so the impact is zero to the normal way people use these cards.
patch #3 is an optimization, patch #4 is mostly cosmetical.
Cheers,
Auke
next prev parent reply other threads:[~2007-10-25 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 20:57 [PATCH 1/4] e1000e: Fix jumbo frame receive code Auke Kok
2007-10-25 20:57 ` [PATCH 2/4] e1000e: Fix PBA calculation for jumbo frame packets Auke Kok
2007-10-25 20:57 ` [PATCH 3/4] e1000e: Re-enable SECRC - crc stripping Auke Kok
2007-10-25 20:58 ` [PATCH 4/4] e1000e: Remove legacy jumbo frame receive code Auke Kok
2007-10-25 21:05 ` Kok, Auke [this message]
2007-10-29 9:47 ` [PATCH 1/4] e1000e: Fix " Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47210525.4020606@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.