* [PATCH] Prevent appletouch message log spam on 17" PB
@ 2007-10-28 23:53 Joseph Jezak
2007-10-29 2:21 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Jezak @ 2007-10-28 23:53 UTC (permalink / raw)
To: dtor; +Cc: linuxppc-dev, valderman
Perhaps this was a debugging message? In any case, this printk
causes lots of message log spam on my PB G4 1.67" (PowerBook5,9).
This removes the printk.
Signed-off by: Joseph Jezak <josejx@gentoo.org>
---
diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
index f132702..6c47641 100644
--- a/drivers/input/mouse/appletouch.c
+++ b/drivers/input/mouse/appletouch.c
@@ -433,7 +433,6 @@ static void atp_complete(struct urb* urb)
for (i = (atp_is_geyser_2(dev)?15:16); i < ATP_XSENSORS; i++) {
if (!dev->xy_cur[i]) continue;
- printk("appletouch: 17\" model detected.\n");
if(atp_is_geyser_2(dev))
input_set_abs_params(dev->input, ABS_X, 0,
(20 - 1) *
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Prevent appletouch message log spam on 17" PB
2007-10-28 23:53 [PATCH] Prevent appletouch message log spam on 17" PB Joseph Jezak
@ 2007-10-29 2:21 ` Dmitry Torokhov
2007-10-29 2:34 ` Joseph Jezak
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2007-10-29 2:21 UTC (permalink / raw)
To: Joseph Jezak; +Cc: linuxppc-dev, valderman, Johannes Berg
Hi Joseph,
On Sunday 28 October 2007 19:53, Joseph Jezak wrote:
> Perhaps this was a debugging message? In any case, this printk
> causes lots of message log spam on my PB G4 1.67" (PowerBook5,9).
>
> This removes the printk.
>
I don't think we want do delete this message outright, we just need
to make sure we don't go through size detection when we re-initialize
the device. After all it is unlikely that touchpad will change its
size :)
BTW, could you tell me what product ID your touchpad has?
> Signed-off by: Joseph Jezak <josejx@gentoo.org>
> ---
>
> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
> index f132702..6c47641 100644
> --- a/drivers/input/mouse/appletouch.c
> +++ b/drivers/input/mouse/appletouch.c
> @@ -433,7 +433,6 @@ static void atp_complete(struct urb* urb)
> for (i = (atp_is_geyser_2(dev)?15:16); i < ATP_XSENSORS; i++) {
> if (!dev->xy_cur[i]) continue;
>
> - printk("appletouch: 17\" model detected.\n");
> if(atp_is_geyser_2(dev))
> input_set_abs_params(dev->input, ABS_X, 0,
> (20 - 1) *
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Prevent appletouch message log spam on 17" PB
2007-10-29 2:21 ` Dmitry Torokhov
@ 2007-10-29 2:34 ` Joseph Jezak
0 siblings, 0 replies; 3+ messages in thread
From: Joseph Jezak @ 2007-10-29 2:34 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Johannes Berg, linuxppc-dev, Joseph Jezak, valderman
Dmitry Torokhov wrote:
> Hi Joseph,
>
> On Sunday 28 October 2007 19:53, Joseph Jezak wrote:
>> Perhaps this was a debugging message? In any case, this printk
>> causes lots of message log spam on my PB G4 1.67" (PowerBook5,9).
>>
>> This removes the printk.
>>
>
> I don't think we want do delete this message outright, we just need
> to make sure we don't go through size detection when we re-initialize
> the device. After all it is unlikely that touchpad will change its
> size :)
>
> BTW, could you tell me what product ID your touchpad has?
>
>> Signed-off by: Joseph Jezak <josejx@gentoo.org>
>> ---
>>
>> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
>> index f132702..6c47641 100644
>> --- a/drivers/input/mouse/appletouch.c
>> +++ b/drivers/input/mouse/appletouch.c
>> @@ -433,7 +433,6 @@ static void atp_complete(struct urb* urb)
>> for (i = (atp_is_geyser_2(dev)?15:16); i < ATP_XSENSORS; i++) {
>> if (!dev->xy_cur[i]) continue;
>>
>> - printk("appletouch: 17\" model detected.\n");
>> if(atp_is_geyser_2(dev))
>> input_set_abs_params(dev->input, ABS_X, 0,
>> (20 - 1) *
>>
>
Sure, that's probably better. My touchpad is an 0x0214.
-Joe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-29 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-28 23:53 [PATCH] Prevent appletouch message log spam on 17" PB Joseph Jezak
2007-10-29 2:21 ` Dmitry Torokhov
2007-10-29 2:34 ` Joseph Jezak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.