From: Diederik de Haas <didi.debian@cknow.org>
To: Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Jonas Karlman <jonas@kwiboo.se>
Cc: Christopher Obbard <chris.obbard@collabora.com>,
Andy Yan <andy.yan@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full
Date: Mon, 20 Nov 2023 15:31:59 +0100 [thread overview]
Message-ID: <4726930.fbnEVBQaF0@bagend> (raw)
In-Reply-To: <20231026191500.2994225-1-jonas@kwiboo.se>
[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]
On Thursday, 26 October 2023 21:14:58 CET Jonas Karlman wrote:
> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
> and RK3399 result in wrong colors being displayed.
>
> The issue can be observed using modetest:
>
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@RG24
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@BG24
On my Rock64 (rk3328) I was able to see the problem without this patch and see
it displaying correctly with it, so
Tested-by: Diederik de Haas <didi.debian@cknow.org>
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Diederik de Haas <didi.debian@cknow.org>
To: Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Jonas Karlman <jonas@kwiboo.se>
Cc: Christopher Obbard <chris.obbard@collabora.com>,
Andy Yan <andy.yan@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full
Date: Mon, 20 Nov 2023 15:31:59 +0100 [thread overview]
Message-ID: <4726930.fbnEVBQaF0@bagend> (raw)
In-Reply-To: <20231026191500.2994225-1-jonas@kwiboo.se>
[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]
On Thursday, 26 October 2023 21:14:58 CET Jonas Karlman wrote:
> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
> and RK3399 result in wrong colors being displayed.
>
> The issue can be observed using modetest:
>
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@RG24
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@BG24
On my Rock64 (rk3328) I was able to see the problem without this patch and see
it displaying correctly with it, so
Tested-by: Diederik de Haas <didi.debian@cknow.org>
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Diederik de Haas <didi.debian@cknow.org>
To: Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Jonas Karlman <jonas@kwiboo.se>
Cc: Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Andy Yan <andy.yan@rock-chips.com>,
Christopher Obbard <chris.obbard@collabora.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full
Date: Mon, 20 Nov 2023 15:31:59 +0100 [thread overview]
Message-ID: <4726930.fbnEVBQaF0@bagend> (raw)
In-Reply-To: <20231026191500.2994225-1-jonas@kwiboo.se>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Thursday, 26 October 2023 21:14:58 CET Jonas Karlman wrote:
> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
> and RK3399 result in wrong colors being displayed.
>
> The issue can be observed using modetest:
>
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@RG24
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@BG24
On my Rock64 (rk3328) I was able to see the problem without this patch and see
it displaying correctly with it, so
Tested-by: Diederik de Haas <didi.debian@cknow.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Diederik de Haas <didi.debian@cknow.org>
To: Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Jonas Karlman <jonas@kwiboo.se>
Cc: Christopher Obbard <chris.obbard@collabora.com>,
Andy Yan <andy.yan@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full
Date: Mon, 20 Nov 2023 15:31:59 +0100 [thread overview]
Message-ID: <4726930.fbnEVBQaF0@bagend> (raw)
In-Reply-To: <20231026191500.2994225-1-jonas@kwiboo.se>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Thursday, 26 October 2023 21:14:58 CET Jonas Karlman wrote:
> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
> and RK3399 result in wrong colors being displayed.
>
> The issue can be observed using modetest:
>
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@RG24
> modetest -s <connector_id>@<crtc_id>:1920x1080-60@BG24
On my Rock64 (rk3328) I was able to see the problem without this patch and see
it displaying correctly with it, so
Tested-by: Diederik de Haas <didi.debian@cknow.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-20 14:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 19:14 [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full Jonas Karlman
2023-10-26 19:14 ` Jonas Karlman
2023-10-26 19:14 ` Jonas Karlman
2023-10-26 19:14 ` Jonas Karlman
2023-10-26 20:02 ` Christopher Obbard
2023-10-26 20:02 ` Christopher Obbard
2023-10-26 20:02 ` Christopher Obbard
2023-10-26 20:02 ` Christopher Obbard
2023-10-26 20:33 ` Jonas Karlman
2023-10-26 20:33 ` Jonas Karlman
2023-10-26 20:33 ` Jonas Karlman
2023-10-26 20:33 ` Jonas Karlman
2023-11-20 14:31 ` Diederik de Haas [this message]
2023-11-20 14:31 ` Diederik de Haas
2023-11-20 14:31 ` Diederik de Haas
2023-11-20 14:31 ` Diederik de Haas
2023-11-20 16:13 ` Heiko Stuebner
2023-11-20 16:13 ` Heiko Stuebner
2023-11-20 16:13 ` Heiko Stuebner
2023-11-20 16:13 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4726930.fbnEVBQaF0@bagend \
--to=didi.debian@cknow.org \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=chris.obbard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.