* [PATCH][NETNS] fix net released by rcu callback
@ 2007-10-30 10:33 Daniel Lezcano
0 siblings, 0 replies; only message in thread
From: Daniel Lezcano @ 2007-10-30 10:33 UTC (permalink / raw)
To: David Miller, Eric W. Biederman; +Cc: Linux Netdev List, Linux Containers
When a network namespace reference is held by a network subsystem,
and when this reference is decremented in a rcu update callback, we
must ensure that there is no more outstanding rcu update before
trying to free the network namespace.
In the normal case, the rcu_barrier is called when the network namespace
is exiting in the cleanup_net function.
But when a network namespace creation fails, and the subsystems are
undone (like the cleanup), the rcu_barrier is missing.
This patch adds the missing rcu_barrier.
Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
---
net/core/net_namespace.c | 2 ++
1 file changed, 2 insertions(+)
Index: net-2.6/net/core/net_namespace.c
===================================================================
--- net-2.6.orig/net/core/net_namespace.c
+++ net-2.6/net/core/net_namespace.c
@@ -112,6 +112,8 @@ out_undo:
if (ops->exit)
ops->exit(net);
}
+
+ rcu_barrier();
goto out;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-30 10:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 10:33 [PATCH][NETNS] fix net released by rcu callback Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.