Re: [PATCH] Fix format warning in sound/isa/ad1848/ad1848_lib.c

Re: [PATCH] Fix format warning in sound/isa/ad1848/ad1848_lib.c

[Takashi Iwai]

At Wed, 31 Oct 2007 15:11:03 +0100,
Gabriel C wrote:
> 
> Hi,
> 
> I see this warning on current git head :
> 
> ...
> 
> sound/isa/ad1848/ad1848_lib.c: In function 'snd_ad1848_mce_down':
> sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> 
> ...
> 
> Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>

The fix has been in ALSA tree since a week ago...  Sigh.

Jaroslav, please prepare the push?


thanks,

Takashi

> 
> ---
> 
>  sound/isa/ad1848/ad1848_lib.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
> index a901cd1..9a64035 100644
> --- a/sound/isa/ad1848/ad1848_lib.c
> +++ b/sound/isa/ad1848/ad1848_lib.c
> @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
>  	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
>  		udelay(100);
>  
> -	snd_printdd("(1) timeout = %d\n", timeout);
> +	snd_printdd("(1) timeout = %ld\n", timeout);
>  
>  #ifdef CONFIG_SND_DEBUG
>  	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

[PATCH] Fix format warning in sound/isa/ad1848/ad1848_lib.c

[Gabriel C]

Hi,

I see this warning on current git head :

...

sound/isa/ad1848/ad1848_lib.c: In function 'snd_ad1848_mce_down':
sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

...

Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>

---

 sound/isa/ad1848/ad1848_lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
index a901cd1..9a64035 100644
--- a/sound/isa/ad1848/ad1848_lib.c
+++ b/sound/isa/ad1848/ad1848_lib.c
@@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
 	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
 		udelay(100);
 
-	snd_printdd("(1) timeout = %d\n", timeout);
+	snd_printdd("(1) timeout = %ld\n", timeout);
 
 #ifdef CONFIG_SND_DEBUG
 	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)