From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Restore deterministic CPU accounting on powerpc
Date: Sat, 03 Nov 2007 22:17:41 +0530 [thread overview]
Message-ID: <472CA62D.8050205@linux.vnet.ibm.com> (raw)
In-Reply-To: <18220.24362.604297.53633@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Balbir Singh writes:
>
>> So, scaled accounting will not be available if
>> CONFIG_VIRT_CPU_ACCOUNTING is defined? Am I reading this correctly
>
> No, what makes you think that? If VIRT_CPU_ACCOUNTING=y it is the
> responsibility of the arch's account_process_tick to update the scaled
> stats. And the powerpc version does that by calling
> account_user_time_scaled().
>
> Paul.
I looked at the diff's and could just see the reversal of scaled
accounting. I looked at account_process_vtime(), now
account_process_tick() and things seem fine. I was mislead by the
diff.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Restore deterministic CPU accounting on powerpc
Date: Sat, 03 Nov 2007 22:17:41 +0530 [thread overview]
Message-ID: <472CA62D.8050205@linux.vnet.ibm.com> (raw)
In-Reply-To: <18220.24362.604297.53633@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Balbir Singh writes:
>
>> So, scaled accounting will not be available if
>> CONFIG_VIRT_CPU_ACCOUNTING is defined? Am I reading this correctly
>
> No, what makes you think that? If VIRT_CPU_ACCOUNTING=y it is the
> responsibility of the arch's account_process_tick to update the scaled
> stats. And the powerpc version does that by calling
> account_user_time_scaled().
>
> Paul.
I looked at the diff's and could just see the reversal of scaled
accounting. I looked at account_process_vtime(), now
account_process_tick() and things seem fine. I was mislead by the
diff.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2007-11-03 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 4:48 [PATCH] Restore deterministic CPU accounting on powerpc Paul Mackerras
2007-11-02 4:48 ` Paul Mackerras
2007-11-02 7:49 ` Martin Schwidefsky
2007-11-02 7:49 ` Martin Schwidefsky
2007-11-03 8:54 ` Ingo Molnar
2007-11-03 8:54 ` Ingo Molnar
2007-11-03 9:32 ` Ingo Molnar
2007-11-03 9:32 ` Ingo Molnar
2007-11-03 12:06 ` Paul Mackerras
2007-11-03 12:06 ` Paul Mackerras
2007-11-03 9:02 ` Balbir Singh
2007-11-03 9:02 ` Balbir Singh
2007-11-03 11:44 ` Paul Mackerras
2007-11-03 11:44 ` Paul Mackerras
2007-11-03 16:47 ` Balbir Singh [this message]
2007-11-03 16:47 ` Balbir Singh
2007-11-04 12:11 ` Michael Neuling
2007-11-04 12:11 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472CA62D.8050205@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.