* [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24
@ 2007-11-06 19:40 Tony Battersby
2007-11-07 17:43 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Tony Battersby @ 2007-11-06 19:40 UTC (permalink / raw)
To: Matthew Wilcox, linux-scsi
The following commit changed the pointer passed to request_irq(), but
failed to change the pointer passed to free_irq():
commit 99c9e0a1d6cfe1ba1169a7a81435ee85bc00e4a1
Author: Matthew Wilcox <matthew@wil.cx>
Date: Fri Oct 5 15:55:12 2007 -0400
[SCSI] sym53c8xx: Make interrupt handler capable of returning IRQ_NONE
...
The result is that free_irq() doesn't actually take any action. This
patch fixes it.
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
---
--- linux-2.6.24-rc1-git15/drivers/scsi/sym53c8xx_2/sym_glue.c.orig 2007-11-06 14:22:43.000000000 -0500
+++ linux-2.6.24-rc1-git15/drivers/scsi/sym53c8xx_2/sym_glue.c 2007-11-06 14:22:59.000000000 -0500
@@ -1243,7 +1243,7 @@ static void sym_free_resources(struct sy
* Free O/S specific resources.
*/
if (pdev->irq)
- free_irq(pdev->irq, np);
+ free_irq(pdev->irq, np->s.host);
if (np->s.ioaddr)
pci_iounmap(pdev, np->s.ioaddr);
if (np->s.ramaddr)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24
2007-11-06 19:40 [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24 Tony Battersby
@ 2007-11-07 17:43 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-11-07 17:43 UTC (permalink / raw)
To: Tony Battersby; +Cc: Matthew Wilcox, linux-scsi
On Tue, Nov 06, 2007 at 02:40:54PM -0500, Tony Battersby wrote:
> The following commit changed the pointer passed to request_irq(), but
> failed to change the pointer passed to free_irq():
Looks good.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-07 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-06 19:40 [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24 Tony Battersby
2007-11-07 17:43 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.