From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: grub2 ChangeLog term/i386/pc/serial.c
Date: Wed, 07 Nov 2007 22:35:17 +0200 [thread overview]
Message-ID: <47322185.2040005@nic.fi> (raw)
In-Reply-To: <20071107201907.GB10337@thorin>
Robert Millan wrote:
> On Tue, Nov 06, 2007 at 11:33:44PM +0200, Vesa Jääskeläinen wrote:
>>> * term/i386/pc/serial.c (serial_hw_put): Switch order of arguments
>>> in grub_outb() calls.
>> Why on earth those parameters are reversed anyway :) ?
>
> My fault :-)
>
> When I replaced inb() and outb() in that file, I assumed they would have
> the same semantics as grub_inb() and grub_outb().
Just to be clear, I would have understood your rational ordering better
than current version ;)
> grub_inb() and grub_outb() are based on the inb()/outb() implementation
> from glibc headers, so I kept the same arguments for consistency.
I see... Once again inconsistency introduced by Unix folks... as AT&T
assembler wouldn't be enough, they then poisons C libs too... oh well...
another thing to try to keep in mind...
next prev parent reply other threads:[~2007-11-07 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1IpVtw-0001l3-2T@cvs.savannah.gnu.org>
2007-11-06 21:33 ` grub2 ChangeLog term/i386/pc/serial.c Vesa Jääskeläinen
2007-11-07 20:19 ` Robert Millan
2007-11-07 20:35 ` Vesa Jääskeläinen [this message]
2007-11-07 21:28 ` Robert Millan
2007-11-09 15:26 ` Marco Gerards
2007-11-09 21:37 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47322185.2040005@nic.fi \
--to=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.