From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [kvm-devel] FreeBSD image hangs during boot
Date: Thu, 08 Nov 2007 11:22:58 +0100 [thread overview]
Message-ID: <4732E382.2070402@bellard.org> (raw)
In-Reply-To: <4732DE33.4080004@qumranet.com>
Avi Kivity wrote:
> Fabrice Bellard wrote:
>> Avi Kivity wrote:
>>> Aurelien Jarno wrote:
>>>> Well the IDE code hasn't changed a lot recently, so I checked the CVS
>>>> history and easily (first test) found the commit that causes the
>>>> problem:
>>>>
>>>> Last AIO patch, by Vladimir N. Oleynik.
>>>>
>>>> http://cvs.savannah.nongnu.org/viewvc/qemu/hw/ide.c?root=qemu&r1=1.64&r2=1.65
>>>>
>>>>
>>>>
>>>
>>> Have we learned something about this issue? Should I revert the patch
>>> from kvm? Should qemu?
>>
>> Sure. The conversion from sync to async mode done in this patch is
>> incomplete to say the least.
>>
>
> Is reverting the patch safe, or will it cause new problems?
The patch must be reverted because it implements incorrectly the AIO
write case (e.g. nsector is modified before the IO actually takes
place). The previous code was at least correct if win2k_install_hack was
not enabled and if one considered than the PIO I/Os were instantaneous.
Regards,
Fabrice.
next prev parent reply other threads:[~2007-11-08 10:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 11:41 FreeBSD image hangs during boot Aurelien Jarno
[not found] ` <47022E7E.3030509-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-02 11:53 ` Laurent Vivier
[not found] ` <47023130.6000805-6ktuUTfB/bM@public.gmane.org>
2007-10-02 12:18 ` Aurelien Jarno
2007-10-02 12:09 ` Avi Kivity
[not found] ` <470234DF.6030802-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-02 12:21 ` Aurelien Jarno
[not found] ` <470237DC.5060008-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-02 12:38 ` Avi Kivity
[not found] ` <47023BBB.3020806-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-10 20:42 ` Aurelien Jarno
2007-10-02 16:27 ` Avi Kivity
[not found] ` <47027161.50004-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-02 16:44 ` Aurelien Jarno
[not found] ` <47027586.9020508-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-02 17:04 ` Aurelien Jarno
[not found] ` <47027A01.5080903-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-02 17:25 ` Aurelien Jarno
[not found] ` <47027F25.80001-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-10 11:17 ` Avi Kivity
[not found] ` <470CB4DE.20707-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-10 11:27 ` Aurelien Jarno
[not found] ` <470CB709.5050205-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-10 11:29 ` Avi Kivity
2007-10-10 13:21 ` Aurelien Jarno
[not found] ` <470CD1F1.20305-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-10-10 13:22 ` Avi Kivity
[not found] ` <470CD22C.5050003-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-10 13:47 ` Aurelien Jarno
2007-10-10 13:47 ` [Qemu-devel] Re: [kvm-devel] " Aurelien Jarno
[not found] ` <470CD7DF.2020906-rXXEIb44qovR7s880joybQ@public.gmane.org>
2007-11-08 6:41 ` Avi Kivity
2007-11-08 6:41 ` [Qemu-devel] Re: [kvm-devel] " Avi Kivity
2007-11-08 9:25 ` Fabrice Bellard
2007-11-08 10:00 ` Avi Kivity
2007-11-08 10:22 ` Fabrice Bellard [this message]
[not found] ` <4732AF9B.9010201-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-08 9:44 ` Aurelien Jarno
2007-11-08 9:44 ` [Qemu-devel] Re: [kvm-devel] " Aurelien Jarno
2007-10-03 12:18 ` Laurent Vivier
2007-10-02 12:26 ` Laurent Vivier
[not found] ` <4702390F.9070809-6ktuUTfB/bM@public.gmane.org>
2007-10-02 12:59 ` Aurelien Jarno
2007-10-05 13:25 ` Laurent Vivier
[not found] ` <47063B31.6000001-6ktuUTfB/bM@public.gmane.org>
2007-10-05 13:51 ` Aurelien Jarno
[not found] ` <20071005135122.GA17767-OqXK5JiLQY5aJl8KAwiEcA@public.gmane.org>
2007-10-05 16:06 ` Laurent Vivier
2007-10-05 16:07 ` Avi Kivity
[not found] ` <47066153.2040406-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-05 16:36 ` Avi Kivity
2007-10-06 8:38 ` Laurent Vivier
[not found] ` <47074989.9080100-6ktuUTfB/bM@public.gmane.org>
2007-10-06 19:31 ` Avi Kivity
2007-10-08 7:57 ` Avi Kivity
[not found] ` <4709E2DF.10701-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-08 8:21 ` Laurent Vivier
[not found] ` <4709E896.1090806-6ktuUTfB/bM@public.gmane.org>
2007-10-08 9:39 ` Avi Kivity
[not found] ` <4709FAC1.8050502-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-08 10:35 ` Laurent Vivier
[not found] ` <470A07FC.80407-6ktuUTfB/bM@public.gmane.org>
2007-10-08 10:47 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4732E382.2070402@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.