From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Glauber de Oliveira Costa <glommer@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Zach Amsden <zach@vmware.com>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Subject: Re: [PATCH RFC 2/7] x86: clean up mm/init_32.c
Date: Thu, 08 Nov 2007 08:39:43 -0800 [thread overview]
Message-ID: <47333BCF.5050503@goop.org> (raw)
In-Reply-To: <5d6222a80711080820j5e095e12k7fd1f1710cd1bd24@mail.gmail.com>
Glauber de Oliveira Costa wrote:
>> - /* Map with big pages if possible, otherwise create normal page tables. */
>> + /* Map with big pages if possible, otherwise
>> + create normal page tables. */
>>
> /*
> * multi comment lines are preferred
> * this way, IIRC ;-)
> */
>
I don't think it's worth turning a one-liner into a great big banner.
J
next prev parent reply other threads:[~2007-11-08 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 1:50 [PATCH RFC 0/7] Unify asm-x86/pgtable.h and page.h Jeremy Fitzhardinge
2007-11-08 1:50 ` [PATCH RFC 1/7] x86: kill mk_pte_huge Jeremy Fitzhardinge
2007-11-08 1:50 ` [PATCH RFC 2/7] x86: clean up mm/init_32.c Jeremy Fitzhardinge
2007-11-08 16:20 ` Glauber de Oliveira Costa
2007-11-08 16:39 ` Jeremy Fitzhardinge [this message]
2007-11-08 1:50 ` [PATCH RFC 3/7] x86: clean up asm-x86/page*.h Jeremy Fitzhardinge
2007-11-08 16:42 ` Glauber de Oliveira Costa
2007-11-08 20:59 ` Jeremy Fitzhardinge
2007-11-08 22:38 ` Glauber de Oliveira Costa
2007-11-08 23:03 ` Jeremy Fitzhardinge
2007-11-08 1:50 ` [PATCH RFC 4/7] x86: unify pgtable*.h Jeremy Fitzhardinge
2007-11-08 1:50 ` [PATCH RFC 5/7] x86: simplify pagetable-related operationsin paravirt.h Jeremy Fitzhardinge
2007-11-08 1:50 ` [PATCH RFC 6/7] x86/xen: simplify Xen mmu operations Jeremy Fitzhardinge
2007-11-08 1:50 ` [PATCH RFC 7/7] x86: fix up formatting in pgtable*.h Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47333BCF.5050503@goop.org \
--to=jeremy@goop.org \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=ak@suse.de \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.