All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber de Oliveira Costa <gcosta@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org, lguest@ozlabs.org,
	kvm-devel@lists.sourceforge.net, ak@suse.de,
	virtualization@lists.linux-foundation.org, chrisw@sous-sol.org,
	tglx@linutronix.de, anthony@codemonkey.ws,
	akpm@linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	mingo@elte.hu
Subject: Re: [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included
Date: Fri, 09 Nov 2007 23:26:59 -0200	[thread overview]
Message-ID: <473508E3.1050903@redhat.com> (raw)
In-Reply-To: <4734E6A0.6070508@goop.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Fitzhardinge escreveu:
> Glauber de Oliveira Costa wrote:
>> mm/sparse-vmemmap.c uses init_mm in some places.  However, it is not
>> present in any of the headers currently included in the file.
>>
>> init_mm is defined as extern in sched.h, so we add it to the headers list
>>
>> Up to now, this problem was masked by the fact that functions like
>> set_pte_at() and pmd_populate_kernel() are usually macros that expand to
>> simpler variants that does not use the first parameter at all.
>>
>> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>> ---
>>  mm/sparse-vmemmap.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
>> index d3b718b..22620f6 100644
>> --- a/mm/sparse-vmemmap.c
>> +++ b/mm/sparse-vmemmap.c
>> @@ -24,6 +24,7 @@
>>  #include <linux/module.h>
>>  #include <linux/spinlock.h>
>>  #include <linux/vmalloc.h>
>> +#include <linux/sched.h>
>>   
> 
> This is already in git.
> 
>     J
As I told in the 0th message, yes, I'm aware.
Just it does not seem to be in tglx's , so if people are willing to try
this out, they'll needed. Thus it's included in the series.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Remi - http://enigmail.mozdev.org

iD8DBQFHNQjijYI8LaFUWXMRAn+UAJ48V1EyWoXkWu1+J0Y0ze59H7ZG2QCcDdgW
4qVJgJcQDfJrvZk8TSo901s=
=RwdO
-----END PGP SIGNATURE-----

WARNING: multiple messages have this Message-ID (diff)
From: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jeremy Fitzhardinge <jeremy-TSDbQ3PG+2Y@public.gmane.org>
Cc: lguest-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	ak-l3A5Bk7waGM@public.gmane.org
Subject: Re: [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included
Date: Fri, 09 Nov 2007 23:26:59 -0200	[thread overview]
Message-ID: <473508E3.1050903@redhat.com> (raw)
In-Reply-To: <4734E6A0.6070508-TSDbQ3PG+2Y@public.gmane.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Fitzhardinge escreveu:
> Glauber de Oliveira Costa wrote:
>> mm/sparse-vmemmap.c uses init_mm in some places.  However, it is not
>> present in any of the headers currently included in the file.
>>
>> init_mm is defined as extern in sched.h, so we add it to the headers list
>>
>> Up to now, this problem was masked by the fact that functions like
>> set_pte_at() and pmd_populate_kernel() are usually macros that expand to
>> simpler variants that does not use the first parameter at all.
>>
>> Signed-off-by: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
>> Signed-off-by: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
>> ---
>>  mm/sparse-vmemmap.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
>> index d3b718b..22620f6 100644
>> --- a/mm/sparse-vmemmap.c
>> +++ b/mm/sparse-vmemmap.c
>> @@ -24,6 +24,7 @@
>>  #include <linux/module.h>
>>  #include <linux/spinlock.h>
>>  #include <linux/vmalloc.h>
>> +#include <linux/sched.h>
>>   
> 
> This is already in git.
> 
>     J
As I told in the 0th message, yes, I'm aware.
Just it does not seem to be in tglx's , so if people are willing to try
this out, they'll needed. Thus it's included in the series.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Remi - http://enigmail.mozdev.org

iD8DBQFHNQjijYI8LaFUWXMRAn+UAJ48V1EyWoXkWu1+J0Y0ze59H7ZG2QCcDdgW
4qVJgJcQDfJrvZk8TSo901s=
=RwdO
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  reply	other threads:[~2007-11-10  1:26 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09 18:42 [PATCH 0/24] paravirt_ops for unified x86 - that's me again! Glauber de Oliveira Costa
2007-11-09 18:42 ` Glauber de Oliveira Costa
2007-11-09 18:42 ` [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included Glauber de Oliveira Costa
2007-11-09 18:42 ` Glauber de Oliveira Costa
2007-11-09 18:42   ` Glauber de Oliveira Costa
2007-11-09 18:42   ` [PATCH 2/24] irqflags consolidation Glauber de Oliveira Costa
2007-11-09 18:42   ` Glauber de Oliveira Costa
2007-11-09 18:42     ` Glauber de Oliveira Costa
2007-11-09 18:42     ` [PATCH 3/24] consolidate spinlock.h Glauber de Oliveira Costa
2007-11-09 18:42       ` Glauber de Oliveira Costa
2007-11-09 18:42       ` [PATCH 4/24] tlb functions consolidation Glauber de Oliveira Costa
2007-11-09 18:42       ` Glauber de Oliveira Costa
2007-11-09 18:42         ` Glauber de Oliveira Costa
2007-11-09 18:42         ` [PATCH 5/24] smp x86 consolidation Glauber de Oliveira Costa
2007-11-09 18:42           ` Glauber de Oliveira Costa
2007-11-09 18:42           ` [PATCH 6/24] Add debugreg/load_rsp native hooks Glauber de Oliveira Costa
2007-11-09 18:42             ` Glauber de Oliveira Costa
2007-11-09 18:42             ` [PATCH 7/24] consolidate msr.h Glauber de Oliveira Costa
2007-11-09 18:42             ` Glauber de Oliveira Costa
2007-11-09 18:42               ` Glauber de Oliveira Costa
2007-11-09 18:42               ` [PATCH 8/24] consolidate system.h Glauber de Oliveira Costa
2007-11-09 18:42               ` Glauber de Oliveira Costa
2007-11-09 18:42                 ` Glauber de Oliveira Costa
2007-11-09 18:42                 ` [PATCH 9/24] Wipe out traditional opt from x86_64 Makefile Glauber de Oliveira Costa
2007-11-09 18:42                   ` Glauber de Oliveira Costa
2007-11-09 18:42                   ` [PATCH 10/24] paravirt hooks at entry functions Glauber de Oliveira Costa
2007-11-09 18:42                   ` Glauber de Oliveira Costa
2007-11-09 18:42                     ` Glauber de Oliveira Costa
2007-11-09 18:42                     ` [PATCH 11/24] read/write_crX, clts and wbinvd for 64-bit paravirt Glauber de Oliveira Costa
2007-11-09 18:42                       ` Glauber de Oliveira Costa
2007-11-09 18:42                       ` [PATCH 12/24] provide native irq initialization function Glauber de Oliveira Costa
2007-11-09 18:42                         ` Glauber de Oliveira Costa
2007-11-09 18:42                         ` [PATCH 13/24] report ring kernel is running without paravirt Glauber de Oliveira Costa
2007-11-09 18:42                         ` Glauber de Oliveira Costa
2007-11-09 18:42                           ` Glauber de Oliveira Costa
2007-11-09 18:42                           ` [PATCH 14/24] export math_state_restore Glauber de Oliveira Costa
2007-11-09 18:42                             ` Glauber de Oliveira Costa
2007-11-09 18:42                             ` [PATCH 15/24] native versions for set pagetables Glauber de Oliveira Costa
2007-11-09 18:42                               ` Glauber de Oliveira Costa
2007-11-09 18:42                               ` [PATCH 16/24] add native functions for descriptors handling Glauber de Oliveira Costa
2007-11-09 18:42                                 ` Glauber de Oliveira Costa
2007-11-09 18:42                                 ` [PATCH 17/24] This patch add provisions for time related functions so they Glauber de Oliveira Costa
2007-11-09 18:42                                   ` Glauber de Oliveira Costa
2007-11-09 18:42                                   ` [PATCH 18/24] export cpu_gdt_descr Glauber de Oliveira Costa
2007-11-09 18:42                                     ` Glauber de Oliveira Costa
2007-11-09 18:43                                     ` [PATCH 19/24] turn priviled operation into a macro in head_64.S Glauber de Oliveira Costa
2007-11-09 18:43                                       ` Glauber de Oliveira Costa
2007-11-09 18:43                                       ` [PATCH 20/24] tweak io_64.h for paravirt Glauber de Oliveira Costa
2007-11-09 18:43                                         ` Glauber de Oliveira Costa
2007-11-09 18:43                                         ` [PATCH 21/24] native versions for page table entries values Glauber de Oliveira Costa
2007-11-09 18:43                                         ` Glauber de Oliveira Costa
2007-11-09 18:43                                           ` Glauber de Oliveira Costa
2007-11-09 18:43                                           ` [PATCH 22/24] prepare x86_64 architecture initialization for paravirt Glauber de Oliveira Costa
2007-11-09 18:43                                             ` Glauber de Oliveira Costa
2007-11-09 18:43                                             ` [PATCH 23/24] consolidation of paravirt for 32 and 64 bits Glauber de Oliveira Costa
2007-11-09 18:43                                             ` Glauber de Oliveira Costa
2007-11-09 18:43                                               ` Glauber de Oliveira Costa
2007-11-09 18:43                                               ` [PATCH 24/24] make vsmp a paravirt client Glauber de Oliveira Costa
2007-11-09 18:43                                               ` Glauber de Oliveira Costa
2007-11-09 18:43                                                 ` Glauber de Oliveira Costa
2007-11-11 18:07                                                 ` Andi Kleen
2007-11-11 18:07                                                 ` Andi Kleen
2007-11-11 18:07                                                   ` Andi Kleen
2007-11-13 11:36                                                   ` Glauber de Oliveira Costa
2007-11-13 11:36                                                   ` Glauber de Oliveira Costa
2007-11-13 11:36                                                     ` Glauber de Oliveira Costa
2007-11-13 12:33                                                     ` Andi Kleen
2007-11-13 12:33                                                     ` Andi Kleen
2007-11-13 12:33                                                       ` Andi Kleen
2007-11-13 12:51                                                       ` Glauber de Oliveira Costa
2007-11-13 12:51                                                         ` Glauber de Oliveira Costa
2007-11-13 13:09                                                         ` Andi Kleen
2007-11-13 13:09                                                           ` Andi Kleen
2007-11-13 18:49                                                           ` Ravikiran Thirumalai
2007-11-13 18:49                                                           ` Ravikiran Thirumalai
2007-11-13 18:49                                                             ` Ravikiran Thirumalai
2007-11-13 13:09                                                         ` Andi Kleen
2007-11-13 17:21                                                         ` Jeremy Fitzhardinge
2007-11-13 17:21                                                         ` Jeremy Fitzhardinge
2007-11-13 17:21                                                           ` Jeremy Fitzhardinge
2007-11-13 12:51                                                       ` Glauber de Oliveira Costa
2007-11-13 18:00                                                     ` Ravikiran Thirumalai
2007-11-13 18:00                                                     ` Ravikiran Thirumalai
2007-11-13 18:00                                                       ` Ravikiran Thirumalai
2007-11-09 18:43                                           ` [PATCH 22/24] prepare x86_64 architecture initialization for paravirt Glauber de Oliveira Costa
2007-11-09 18:43                                       ` [PATCH 20/24] tweak io_64.h " Glauber de Oliveira Costa
2007-11-09 18:43                                     ` [PATCH 19/24] turn priviled operation into a macro in head_64.S Glauber de Oliveira Costa
2007-11-09 18:42                                   ` [PATCH 18/24] export cpu_gdt_descr Glauber de Oliveira Costa
2007-11-09 18:42                                 ` [PATCH 17/24] This patch add provisions for time related functions so they Glauber de Oliveira Costa
2007-11-09 18:42                               ` [PATCH 16/24] add native functions for descriptors handling Glauber de Oliveira Costa
2007-11-09 18:42                             ` [PATCH 15/24] native versions for set pagetables Glauber de Oliveira Costa
2007-11-09 18:42                           ` [PATCH 14/24] export math_state_restore Glauber de Oliveira Costa
2007-11-09 18:42                       ` [PATCH 12/24] provide native irq initialization function Glauber de Oliveira Costa
2007-11-09 18:42                     ` [PATCH 11/24] read/write_crX, clts and wbinvd for 64-bit paravirt Glauber de Oliveira Costa
2007-11-09 18:42                 ` [PATCH 9/24] Wipe out traditional opt from x86_64 Makefile Glauber de Oliveira Costa
2007-11-19 22:21               ` [PATCH 7/24] consolidate msr.h Bastian Blank
2007-11-19 22:21                 ` Bastian Blank
2007-11-19 22:36                 ` Steven Rostedt
2007-11-20  5:51                   ` Ingo Molnar
2007-11-20  5:51                   ` Ingo Molnar
2007-11-20  5:51                     ` Ingo Molnar
2007-11-20  6:14                     ` Steven Rostedt
2007-11-20  6:14                       ` Steven Rostedt
2007-11-20  6:14                     ` Steven Rostedt
2007-11-20  6:16                     ` Steven Rostedt
2007-11-20  6:16                       ` Steven Rostedt
2007-11-20 10:43                       ` Rusty Russell
2007-11-20 10:43                         ` Rusty Russell
2007-11-20 10:43                       ` Rusty Russell
2007-11-20  6:16                     ` Steven Rostedt
2007-11-19 22:36                 ` Steven Rostedt
2007-11-19 22:21               ` Bastian Blank
2007-11-10  0:29           ` [PATCH 5/24] smp x86 consolidation Jeremy Fitzhardinge
2007-11-10  0:29           ` Jeremy Fitzhardinge
2007-11-10  0:29             ` Jeremy Fitzhardinge
2007-11-10  1:29             ` Glauber de Oliveira Costa
2007-11-10  1:29             ` Glauber de Oliveira Costa
2007-11-10  1:29               ` Glauber de Oliveira Costa
2007-11-10  2:08               ` Jeremy Fitzhardinge
2007-11-10  2:08               ` Jeremy Fitzhardinge
2007-11-10  2:08                 ` Jeremy Fitzhardinge
2007-11-17  9:32               ` Ingo Molnar
2007-11-17  9:32               ` Ingo Molnar
2007-11-17  9:32                 ` Ingo Molnar
2007-11-09 18:42         ` Glauber de Oliveira Costa
2007-11-09 18:42     ` [PATCH 3/24] consolidate spinlock.h Glauber de Oliveira Costa
2007-11-09 23:00   ` [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included Jeremy Fitzhardinge
2007-11-09 23:00     ` Jeremy Fitzhardinge
2007-11-10  1:26     ` Glauber de Oliveira Costa [this message]
2007-11-10  1:26       ` Glauber de Oliveira Costa
2007-11-10  1:26     ` Glauber de Oliveira Costa
2007-11-09 23:00   ` Jeremy Fitzhardinge
2007-11-12  8:17 ` [kvm-devel] [PATCH 0/24] paravirt_ops for unified x86 - that's me again! Amit Shah
2007-11-12  8:17   ` Amit Shah
2007-11-13 11:43   ` [kvm-devel] " Glauber de Oliveira Costa
2007-11-13 11:43     ` Glauber de Oliveira Costa
2007-11-13 11:43   ` [kvm-devel] " Glauber de Oliveira Costa
2007-11-13 20:26   ` Jeremy Fitzhardinge
2007-11-13 20:26   ` Jeremy Fitzhardinge
2007-11-13 20:26     ` Jeremy Fitzhardinge
2007-11-12  8:17 ` [kvm-devel] " Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473508E3.1050903@redhat.com \
    --to=gcosta@redhat.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=anthony@codemonkey.ws \
    --cc=chrisw@sous-sol.org \
    --cc=jeremy@goop.org \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=lguest@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.