All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Allow build without dirent.d_type, fix "ls (host)" crash
Date: Sat, 10 Nov 2007 19:16:40 +0100	[thread overview]
Message-ID: <4735F588.5020401@t-online.de> (raw)
In-Reply-To: <87ve8agk9n.fsf@xs4all.nl>

Marco Gerards wrote:
>> ...
>> 2007-11-09  Christian Franke  <franke@computer.org>
>>
>> 	* util/hostfs.c (is_dir): New function.
>> 	(grub_hostfs_dir):  Handle missing dirent.d_type case.
>> 	(grub_hostfs_read): Add missing fseek().
>> 	(grub_hostfs_label): Clear label pointer.  This fixes a crash
>> 	of grub-emu on "ls (host)".
>>     
>
> Looks fine to me.
>   

Thanks.

> btw, when do you use (host)?  It's intended as a debugging tool.
>   

It was there, it didn't work, and it breaked remaining grub-emu device 
access at all. So I fixed it :-)

Christian




  reply	other threads:[~2007-11-10 18:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 19:50 [PATCH] Allow build without dirent.d_type, fix "ls (host)" crash Christian Franke
2007-11-02 20:59 ` Christian Franke
2007-11-09 14:55   ` Marco Gerards
2007-11-09 21:06     ` Christian Franke
2007-11-10 16:03       ` Marco Gerards
2007-11-10 18:16         ` Christian Franke [this message]
2007-11-18  7:14         ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4735F588.5020401@t-online.de \
    --to=christian.franke@t-online.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.