From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>, Mark Lord <liml@rtr.ca>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: [PATCH 2/2] libata: use ATA_HORKAGE_STUCK_ERR for ATAPI tape drives
Date: Wed, 14 Nov 2007 14:20:38 +0800 [thread overview]
Message-ID: <473A93B6.5040009@tw.ibm.com> (raw)
In-Reply-To: <473A56CE.4080804@gmail.com>
Per Mark's comments, maybe all ATAPI tape drives need ATA_HORKAGE_STUCK_ERR.
This patch applys ATA_HORKAGE_STUCK_ERR for all ATAPI tape drives.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Cc: Mark Lord <liml@rtr.ca>
---
diff -Nrup 01_ide_tape_stuck_err/drivers/ata/libata-core.c 02_black_ide_tape_drives/drivers/ata/libata-core.c
--- 01_ide_tape_stuck_err/drivers/ata/libata-core.c 2007-11-14 11:20:31.000000000 +0800
+++ 02_black_ide_tape_drives/drivers/ata/libata-core.c 2007-11-14 11:45:33.000000000 +0800
@@ -2307,8 +2307,10 @@ int ata_dev_configure(struct ata_device
}
if ((dev->class == ATA_DEV_ATAPI) &&
- (atapi_command_packet_set(id) == TYPE_TAPE))
+ (atapi_command_packet_set(id) == TYPE_TAPE)) {
dev->max_sectors = ATA_MAX_SECTORS_TAPE;
+ dev->horkage |= ATA_HORKAGE_STUCK_ERR;
+ }
if (dev->horkage & ATA_HORKAGE_MAX_SEC_128)
dev->max_sectors = min_t(unsigned int, ATA_MAX_SECTORS_128,
next prev parent reply other threads:[~2007-11-14 6:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 9:24 ATA tape drive STT3401A needs DRQ HSM workaround too Tejun Heo
2007-10-22 9:31 ` Alan Cox
2007-10-22 9:30 ` Tejun Heo
2007-10-22 14:18 ` Mark Lord
2007-10-22 18:37 ` Jeff Garzik
2007-10-22 22:36 ` Mark Lord
2007-11-13 10:08 ` Albert Lee
2007-11-13 10:30 ` [PATCH] libata: workaround DRQ=1 ERR=1 for ATAPI tape drives Albert Lee
2007-11-13 10:35 ` Tejun Heo
2007-11-13 13:49 ` Mark Lord
2007-11-13 14:16 ` Mark Lord
2007-11-13 15:14 ` Alan Cox
2007-11-13 17:24 ` Mark Lord
2007-11-13 18:12 ` Alan Cox
2007-11-13 18:22 ` Mark Lord
2007-11-14 2:00 ` Tejun Heo
2007-11-14 6:13 ` [PATCH 1/2] " Albert Lee
2007-11-14 12:19 ` Alan Cox
2007-11-15 0:32 ` Tejun Heo
2007-11-14 6:20 ` Albert Lee [this message]
2007-11-15 0:33 ` [PATCH 2/2] libata: use ATA_HORKAGE_STUCK_ERR " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473A93B6.5040009@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.