All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Neil Brown <neilb@suse.de>, nfs@lists.sourceforge.net
Subject: Re: Use of delayed request information in nlmsvc_lookup_host
Date: Wed, 14 Nov 2007 14:54:32 -0500	[thread overview]
Message-ID: <473B5278.7090408@oracle.com> (raw)
In-Reply-To: <1195069262.7584.54.camel@heimdal.trondhjem.org>

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Trond Myklebust wrote:
> On Wed, 2007-11-14 at 14:00 -0500, Chuck Lever wrote:
>> That's correct.  I'm just trying to understand why, historically, 
>> rq_daddr was just the 32-bit address and not a full sockaddr to begin 
>> with.  There may be something we're missing, like "we didn't want to add 
>> another large field to this structure due to memory alignment or 
>> allocation efficiency concerns".  :-)
> 
> Actually, rq_daddr by definition pretty much has to be of the same
> address family as rq_addr, since they are the two endpoints for the same
> socket. 
> 
> However I can't see where rq_addr is being initialised for UDP sockets.
> That is sort of worrying given that it is used among other things by the
> nfsd duplicate reply cache...

That's the other half of my question.  Why isn't nlmsvc_lookup_host 
using rq_addr (without the d)?

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 259 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  parent reply	other threads:[~2007-11-14 19:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14 18:23 Use of delayed request information in nlmsvc_lookup_host Chuck Lever
2007-11-14 18:43 ` Trond Myklebust
2007-11-14 19:00   ` Chuck Lever
2007-11-14 19:32     ` J. Bruce Fields
2007-11-14 19:41     ` Trond Myklebust
2007-11-14 19:50       ` Trond Myklebust
2007-11-14 19:54       ` Chuck Lever [this message]
2007-11-15  1:41         ` Neil Brown
2007-11-15 13:55           ` Chuck Lever
2007-11-15 15:54             ` Trond Myklebust
2007-11-15 16:26               ` Chuck Lever
2007-11-15 17:00                 ` Chuck Lever
2007-11-15 17:23               ` Chuck Lever
2007-11-15 17:37                 ` Trond Myklebust
2007-11-15 18:02                   ` Chuck Lever
2007-11-15 16:00             ` Frank van Maarseveen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473B5278.7090408@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.