From: Chuck Lever <chuck.lever@oracle.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Neil Brown <neilb@suse.de>, nfs@lists.sourceforge.net
Subject: Re: Use of delayed request information in nlmsvc_lookup_host
Date: Thu, 15 Nov 2007 11:26:44 -0500 [thread overview]
Message-ID: <473C7344.5090705@oracle.com> (raw)
In-Reply-To: <1195142050.7506.13.camel@heimdal.trondhjem.org>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
Trond Myklebust wrote:
> On Thu, 2007-11-15 at 08:55 -0500, Chuck Lever wrote:
>
>> What do you think of changing the rq_daddr field to be a sockaddr_storage?
>
> Why? You've already got rq_addr.
rq_daddr stores raw address bits, but nlm_host stores a whole sockaddr
for the source address. Should we change nlm_host to store just the raw
address bits as well (svc_addr_u)? AFAICS the only place that needs to
construct a whole sockaddr out of the source address is nlm_bind_host.
In addition, NSM_NOTIFY gets a 4-byte address off the wire, and assumes
it's AF_INET. Should we store this in an in_addr/in_addr6 union as well?
I haven't looked closely at NSM_NOTIFY... is it even possible to send a
non-AF_INET address with this procedure?
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 259 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard
[-- Attachment #3: Type: text/plain, Size: 314 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
[-- Attachment #4: Type: text/plain, Size: 140 bytes --]
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-11-15 16:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 18:23 Use of delayed request information in nlmsvc_lookup_host Chuck Lever
2007-11-14 18:43 ` Trond Myklebust
2007-11-14 19:00 ` Chuck Lever
2007-11-14 19:32 ` J. Bruce Fields
2007-11-14 19:41 ` Trond Myklebust
2007-11-14 19:50 ` Trond Myklebust
2007-11-14 19:54 ` Chuck Lever
2007-11-15 1:41 ` Neil Brown
2007-11-15 13:55 ` Chuck Lever
2007-11-15 15:54 ` Trond Myklebust
2007-11-15 16:26 ` Chuck Lever [this message]
2007-11-15 17:00 ` Chuck Lever
2007-11-15 17:23 ` Chuck Lever
2007-11-15 17:37 ` Trond Myklebust
2007-11-15 18:02 ` Chuck Lever
2007-11-15 16:00 ` Frank van Maarseveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473C7344.5090705@oracle.com \
--to=chuck.lever@oracle.com \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.