smp_call_function_mask not defined in UP kernel.

smp_call_function_mask not defined in UP kernel.

[Zhang, Xiantao]

Hi Avi,
   smp_call_function_mask  is introduced in latest commits, but not
defined in UP configuration. So, it will run into compile fail when
kernel is configured without smp support.  Please check and do the fix
:)
Best Wishes!
Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: smp_call_function_mask not defined in UP kernel.

[Avi Kivity]

Zhang, Xiantao wrote:
> Hi Avi,
>    smp_call_function_mask  is introduced in latest commits, but not
> defined in UP configuration. So, it will run into compile fail when
> kernel is configured without smp support.  Please check and do the fix
> :)
>   

I see it in my include/linux/smp.h:

>
> #define smp_call_function_mask(mask, func, info, wait) \
>                         (up_smp_call_function(func, info))
>
> #endif /* !SMP */

It's fairly new.  Are you sure you are using the latest code?


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: smp_call_function_mask not defined in UP kernel.

[Zhang, Xiantao]

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Hi Avi,
>>    smp_call_function_mask  is introduced in latest commits, but not
>> defined in UP configuration. So, it will run into compile fail when
>> kernel is configured without smp support.  Please check and do the
>> fix :) 
>> 
> 
> I see it in my include/linux/smp.h:
> 
>> 
>> #define smp_call_function_mask(mask, func, info, wait) \
>>                         (up_smp_call_function(func, info))
>> 
>> #endif /* !SMP */
> 
> It's fairly new.  Are you sure you are using the latest code.
 
Seems it is fixed 3 hours ago. 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: smp_call_function_mask not defined in UP kernel.

[Zhang, Xiantao]

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Hi Avi,
>>    smp_call_function_mask  is introduced in latest commits, but not
>> defined in UP configuration. So, it will run into compile fail when
>> kernel is configured without smp support.  Please check and do the
>> fix :) 
>> 
> 
> I see it in my include/linux/smp.h:
> 
>> 
>> #define smp_call_function_mask(mask, func, info, wait) \
>>                         (up_smp_call_function(func, info))
>> 
>> #endif /* !SMP */
> 
> It's fairly new.  Are you sure you are using the latest code?

Hi Avi, 
	Still there is problematic issues here.  If user's kernel is
UP(old kernel, 2.6.23 or older), and he wants to build KVM modules in
kernel-userspace, I think he would meet prolems, because this function
is not defined in those versions. 

BTW,  Seems current KVM source doesn't support UP kernel without kvm
built-in, once we build kvm modules through kvm-userspace.git. 

Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: smp_call_function_mask not defined in UP kernel.

[Avi Kivity]

Zhang, Xiantao wrote:
> Avi Kivity wrote:
>   
>> Zhang, Xiantao wrote:
>>     
>>> Hi Avi,
>>>    smp_call_function_mask  is introduced in latest commits, but not
>>> defined in UP configuration. So, it will run into compile fail when
>>> kernel is configured without smp support.  Please check and do the
>>> fix :) 
>>>
>>>       
>> I see it in my include/linux/smp.h:
>>
>>     
>>> #define smp_call_function_mask(mask, func, info, wait) \
>>>                         (up_smp_call_function(func, info))
>>>
>>> #endif /* !SMP */
>>>       
>> It's fairly new.  Are you sure you are using the latest code?
>>     
>
> Hi Avi, 
> 	Still there is problematic issues here.  If user's kernel is
> UP(old kernel, 2.6.23 or older), and he wants to build KVM modules in
> kernel-userspace, I think he would meet prolems, because this function
> is not defined in those versions. 
>
>   

kernel/external-module-compat.h defines replacements for older kernels. 
If something doesn't work for you, please post the error message.

> BTW,  Seems current KVM source doesn't support UP kernel without kvm
> built-in, once we build kvm modules through kvm-userspace.git. 
>   

Should work, though I never tested it.  Are you seeing an error?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: smp_call_function_mask not defined in UP kernel.

[Zhang, Xiantao]

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Avi Kivity wrote:
>> 
>>> Zhang, Xiantao wrote:
>>> 
>>>> Hi Avi,
>>>>    smp_call_function_mask  is introduced in latest commits, but not
>>>> defined in UP configuration. So, it will run into compile fail when
>>>> kernel is configured without smp support.  Please check and do the
>>>> fix :) 
>>>> 
>>>> 
>>> I see it in my include/linux/smp.h:
>>> 
>>> 
>>>> #define smp_call_function_mask(mask, func, info, wait) \
>>>>                         (up_smp_call_function(func, info))
>>>> 
>>>> #endif /* !SMP */
>>>> 
>>> It's fairly new.  Are you sure you are using the latest code?
>>> 
>> 
>> Hi Avi,
>> 	Still there is problematic issues here.  If user's kernel is
>> UP(old kernel, 2.6.23 or older), and he wants to build KVM modules in
>> kernel-userspace, I think he would meet prolems, because this
>> function is not defined in those versions.
>> 
>> 
> 
> kernel/external-module-compat.h defines replacements for older
> kernels. If something doesn't work for you, please post the error
> message. 
I see now. Don't know this mechanism before :)
 
>> BTW,  Seems current KVM source doesn't support UP kernel without kvm
>> built-in, once we build kvm modules through kvm-userspace.git.
>> 
> 
> Should work, though I never tested it.  Are you seeing an error?

Just have a test. Seems it can't compile pass. The error info as
following:





-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: smp_call_function_mask not defined in UP kernel.

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 2231 bytes --]

 

-----Original Message-----
From: Zhang, Xiantao 
Sent: 2007年11月15日 17:34
To: 'Avi Kivity'
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: RE: [kvm-devel] smp_call_function_mask not defined in UP kernel.

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Avi Kivity wrote:
>> 
>>> Zhang, Xiantao wrote:
>>> 
>>>> Hi Avi,
>>>>    smp_call_function_mask  is introduced in latest commits, but not
>>>> defined in UP configuration. So, it will run into compile fail when
>>>> kernel is configured without smp support.  Please check and do the
>>>> fix :) 
>>>> 
>>>> 
>>> I see it in my include/linux/smp.h:
>>> 
>>> 
>>>> #define smp_call_function_mask(mask, func, info, wait) \
>>>>                         (up_smp_call_function(func, info))
>>>> 
>>>> #endif /* !SMP */
>>>> 
>>> It's fairly new.  Are you sure you are using the latest code?
>>> 
>> 
>> Hi Avi,
>> 	Still there is problematic issues here.  If user's kernel is
>> UP(old kernel, 2.6.23 or older), and he wants to build KVM modules in
>> kernel-userspace, I think he would meet prolems, because this
>> function is not defined in those versions.
>> 
>> 
> 
> kernel/external-module-compat.h defines replacements for older
> kernels. If something doesn't work for you, please post the error
> message. 
I see now. Don't know this mechanism before :)
 
>> BTW,  Seems current KVM source doesn't support UP kernel without kvm
>> built-in, once we build kvm modules through kvm-userspace.git.
>> 
> 
> Should work, though I never tested it.  Are you seeing an error?

Just have a test. Seems it can't compile pass. The error info as following:

In file included from include/asm/io_apic.h:2,
                 from /home/another/xiantao/kvm-userspace/kernel/ioapic.c:43:
include/asm/io_apic_32.h:57: error: syntax error before numeric constant
make[3]: *** [/home/another/xiantao/kvm-userspace/kernel/ioapic.o] Error 1
make[2]: *** [_module_/home/another/xiantao/kvm-userspace/kernel] Error 2
make[2]: Leaving directory `/home/another/xiantao/kvm'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/another/xiantao/kvm-userspace/kernel'
make: *** [kernel] Error 2






[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: smp_call_function_mask not defined in UP kernel.

[Avi Kivity]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Zhang, Xiantao wrote:
>  
>   
>>> BTW,  Seems current KVM source doesn't support UP kernel without kvm
>>> built-in, once we build kvm modules through kvm-userspace.git.
>>>
>>>       
>> Should work, though I never tested it.  Are you seeing an error?
>>     
>
> Just have a test. Seems it can't compile pass. The error info as following:
>
> In file included from include/asm/io_apic.h:2,
>                  from /home/another/xiantao/kvm-userspace/kernel/ioapic.c:43:
> include/asm/io_apic_32.h:57: error: syntax error before numeric constant
> make[3]: *** [/home/another/xiantao/kvm-userspace/kernel/ioapic.o] Error 1
> make[2]: *** [_module_/home/another/xiantao/kvm-userspace/kernel] Error 2
> make[2]: Leaving directory `/home/another/xiantao/kvm'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/home/another/xiantao/kvm-userspace/kernel'
> make: *** [kernel] Error 2
>
>
>
>   

This was reported and fixed a couple of days ago. Are you using the very
latest sources?


-- 
error compiling committee.c: too many arguments to function



[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: smp_call_function_mask not defined in UP kernel.

[Zhang, Xiantao]

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> 
>> 
>>>> BTW,  Seems current KVM source doesn't support UP kernel without
>>>> kvm built-in, once we build kvm modules through kvm-userspace.git.
>>>> 
>>>> 
>>> Should work, though I never tested it.  Are you seeing an error?
>>> 
>> 
>> Just have a test. Seems it can't compile pass. The error info as
>> following: 
>> 
>> In file included from include/asm/io_apic.h:2,
>>                  from
>> /home/another/xiantao/kvm-userspace/kernel/ioapic.c:43:
>> include/asm/io_apic_32.h:57: error: syntax error before numeric
>> constant make[3]: ***
>> [/home/another/xiantao/kvm-userspace/kernel/ioapic.o] Error 1
>> make[2]: *** [_module_/home/another/xiantao/kvm-userspace/kernel]
>> Error 2 make[2]: Leaving directory `/home/another/xiantao/kvm'  
>> make[1]: *** [all] Error 2
>> make[1]: Leaving directory

> 
> This was reported and fixed a couple of days ago. Are you using the
> very latest sources?

Sorry, seems it is also fixed in latest commits. I used an old commit. 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/