From: Fabio Massimo Di Nitto <fabbione@ubuntu.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: tidy up error message
Date: Thu, 15 Nov 2007 16:06:12 +0100 [thread overview]
Message-ID: <473C6064.1030201@ubuntu.com> (raw)
In-Reply-To: <20071115150113.GA8844@redhat.com>
Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>
David Teigland wrote:
> Print error with log_error() to be consistent with others.
>
> Signed-off-by: David Teigland <teigland@redhat.com>
> ---
> fs/gfs2/locking/dlm/mount.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c
> index ab30102..f2efff4 100644
> --- a/fs/gfs2/locking/dlm/mount.c
> +++ b/fs/gfs2/locking/dlm/mount.c
> @@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
> strncpy(data, data_arg, 255);
>
> if (!strlen(data)) {
> - printk(KERN_ERR
> - "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
> + log_error("no mount options, (u)mount helpers not installed");
> return -EINVAL;
> }
>
--
I'm going to make him an offer he can't refuse.
next prev parent reply other threads:[~2007-11-15 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 15:01 [Cluster-devel] [PATCH] gfs2: tidy up error message David Teigland
2007-11-15 15:06 ` Fabio Massimo Di Nitto [this message]
2007-11-15 15:15 ` [Cluster-devel] " Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473C6064.1030201@ubuntu.com \
--to=fabbione@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.