From: Roel Kluin <12o3l@tiscali.nl>
To: tony.luck@intel.com, len.brown@intel.com
Cc: linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH with title] priority fix in acpi_map_lsapic() arch/ia64/kernel/acpi.c
Date: Thu, 15 Nov 2007 23:32:39 +0100 [thread overview]
Message-ID: <473CC907.4040106@tiscali.nl> (raw)
In-Reply-To: <473CC232.6020901@tiscali.nl>
As above should have been its title.
Roel Kluin wrote:
> I have sent this patch before to lkml, but it appears it wasn't picked up. Also
> I have to admit this isn't tested. This is a patch against linus' tree.
>
> ACPI_MADT_ENABLED is defined 1 (include/acpi/actbl1.h 501)
> lapic_flags: an u32 of struct acpi_madt_local_sapic (include/acpi/actbl1.h 467)
> --
> '!' has a higher priority than '&', so as was
> this won't test the first bit, but rather evaluates to false for any non-zero
> lsapic->lapic_flags.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
> index 3d45d24..7d78d22 100644
> --- a/arch/ia64/kernel/acpi.c
> +++ b/arch/ia64/kernel/acpi.c
> @@ -858,7 +858,7 @@ int acpi_map_lsapic(acpi_handle handle, int *pcpu)
> lsapic = (struct acpi_madt_local_sapic *)obj->buffer.pointer;
>
> if ((lsapic->header.type != ACPI_MADT_TYPE_LOCAL_SAPIC) ||
> - (!lsapic->lapic_flags & ACPI_MADT_ENABLED)) {
> + (!(lsapic->lapic_flags & ACPI_MADT_ENABLED))) {
> kfree(buffer.pointer);
> return -EINVAL;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Roel Kluin <12o3l@tiscali.nl>
To: tony.luck@intel.com, len.brown@intel.com
Cc: linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH with title] priority fix in acpi_map_lsapic() arch/ia64/kernel/acpi.c
Date: Thu, 15 Nov 2007 22:32:39 +0000 [thread overview]
Message-ID: <473CC907.4040106@tiscali.nl> (raw)
In-Reply-To: <473CC232.6020901@tiscali.nl>
As above should have been its title.
Roel Kluin wrote:
> I have sent this patch before to lkml, but it appears it wasn't picked up. Also
> I have to admit this isn't tested. This is a patch against linus' tree.
>
> ACPI_MADT_ENABLED is defined 1 (include/acpi/actbl1.h 501)
> lapic_flags: an u32 of struct acpi_madt_local_sapic (include/acpi/actbl1.h 467)
> --
> '!' has a higher priority than '&', so as was
> this won't test the first bit, but rather evaluates to false for any non-zero
> lsapic->lapic_flags.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
> index 3d45d24..7d78d22 100644
> --- a/arch/ia64/kernel/acpi.c
> +++ b/arch/ia64/kernel/acpi.c
> @@ -858,7 +858,7 @@ int acpi_map_lsapic(acpi_handle handle, int *pcpu)
> lsapic = (struct acpi_madt_local_sapic *)obj->buffer.pointer;
>
> if ((lsapic->header.type != ACPI_MADT_TYPE_LOCAL_SAPIC) ||
> - (!lsapic->lapic_flags & ACPI_MADT_ENABLED)) {
> + (!(lsapic->lapic_flags & ACPI_MADT_ENABLED))) {
> kfree(buffer.pointer);
> return -EINVAL;
> }
>
next prev parent reply other threads:[~2007-11-15 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 22:03 [PATCH] Roel Kluin
2007-11-15 22:03 ` [PATCH] Roel Kluin
2007-11-15 22:32 ` Roel Kluin [this message]
2007-11-15 22:32 ` [PATCH with title] priority fix in acpi_map_lsapic() arch/ia64/kernel/acpi.c Roel Kluin
2007-11-20 6:51 ` Simon Horman
2007-11-20 6:51 ` Simon Horman
2007-12-04 6:22 ` Len Brown
2007-12-04 6:22 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473CC907.4040106@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.