[Cluster-devel] [GFS2] Fix runtime issue with UP kernels

[Cluster-devel] [GFS2] Fix runtime issue with UP kernels

[Fabio Massimo Di Nitto]

Hi Steven,

the patch fixes the issues we discussed on the mailing list before and IRC.

The issue is indeed UP vs SMP and it is totally random.

spin_is_locked() is a bad assertion because there is no correct answer on UP.
on UP spin_is_locked() has to return either one value or another, always.

This means that in my setup I am lucky enough to trigger the issue and your you
are lucky enough not to.

the patch in attachment removes the bogus calls to BUG_ON and according to David
(in CC and thanks for the long explanation on the problem) we can rely upon
things like lockdep to find problem that might be trying to catch.

Please apply.

Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>

Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gfs2_fix_up.diff
Type: application/pgp-encrypted
Size: 1311 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20071116/f50f10ac/attachment.pgp>

[Cluster-devel] Re: [GFS2] Fix runtime issue with UP kernels

[Steven Whitehouse]

Hi,

On Fri, 2007-11-16 at 09:57 +0100, Fabio Massimo Di Nitto wrote:
> Hi Steven,
> 
> the patch fixes the issues we discussed on the mailing list before and IRC.
> 
> The issue is indeed UP vs SMP and it is totally random.
> 
> spin_is_locked() is a bad assertion because there is no correct answer on UP.
> on UP spin_is_locked() has to return either one value or another, always.
> 
> This means that in my setup I am lucky enough to trigger the issue and your you
> are lucky enough not to.
> 
> the patch in attachment removes the bogus calls to BUG_ON and according to David
> (in CC and thanks for the long explanation on the problem) we can rely upon
> things like lockdep to find problem that might be trying to catch.
> 
> Please apply.
> 
> Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>
> 
> Fabio
> 

Ah, all becomes clear :-) Thanks for chasing down this issue, the patch
is in my git tree now. I guess I must have had some other option turned
on when I did my UP build that caused this not to happen,

Steve.

[Cluster-devel] Re: [GFS2] Fix runtime issue with UP kernels

[David Miller]

From: Steven Whitehouse <swhiteho@redhat.com>
Date: Fri, 16 Nov 2007 10:37:43 +0000

> Ah, all becomes clear :-) Thanks for chasing down this issue, the patch
> is in my git tree now. I guess I must have had some other option turned
> on when I did my UP build that caused this not to happen,

Spinlock debugging...